Add reward value of a block in the tile and overview section. #1249

amandasposito · 2018-12-18T13:58:32Z

Resolves #23

Motivation

Displays the reward value in the block tile at the home page, block details page and the address block validated page.

In the tile shows the combined reward value, and at the block details page shows the reward value detail.

Changelog

Bug Fixes

Add :dev dependency to plug_cowboy at the explorer, so iex can start.

coveralls · 2018-12-18T14:07:45Z

Pull Request Test Coverage Report for Build ec16521a-ce23-4f65-9787-cd1aaad13d29

10 of 13 (76.92%) changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.008%) to 86.176%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
apps/block_scout_web/lib/block_scout_web/views/block_view.ex	1	4	25.0%

Totals
Change from base Build 41756a85-718a-4976-82f6-71c475aab948:	-0.008%
Covered Lines:	3734
Relevant Lines:	4333

💛 - Coveralls

apps/block_scout_web/lib/block_scout_web/templates/block/overview.html.eex

+              <dl class="row">
+                <dt class="col-sm-5 text-muted"><%= gettext "Gas Fee" %></dt>
+                <dt class="col-sm-7">
+                  <%= @gas_fee %>


apps/block_scout_web/lib/block_scout_web/views/block_view.ex

+  def show_reward?(_), do: true
+
+  def formatted_reward(block_reward) do
+    {:ok, decimal} = Wei.dump(block_reward.reward)


apps/block_scout_web/lib/block_scout_web/templates/block/overview.html.eex

+
+            <%= if show_reward?(@validator_reward) do %>
+              <dl class="row">
+                <dt class="col-sm-5 text-muted"><%= gettext "Validator Reward" %></dt>


apps/explorer/lib/explorer/chain/transaction.ex

@@ -612,4 +612,11 @@ defmodule Explorer.Chain.Transaction do
      limit: 1
    )
  end
+
+  def block_hash_to_transactions(block_hash) do


apps/block_scout_web/lib/block_scout_web/templates/block/overview.html.eex

+            <%= if show_reward?(@block.rewards) do %>
+              <dl class="row">
+                <dt class="col-sm-3 text-muted"><%= gettext "Gas Used" %></dt>
+                <dt class="col-sm-9">


acravenho · 2018-12-18T20:44:47Z

The layout is looking good but I don't think we're including the gas fee in the calculation. Here is an example:

Chain: POA Core
Block number: 6314183
Number of transactions: 2
Miner Reward displayed: 1 POA (should be 1.000042 POA)
Gas Fee: 42,000
DB Record Shows: 1.000042e+18

amandasposito · 2018-12-19T14:22:48Z

@acravenho I pushed some new changes with this fixed.

acravenho · 2018-12-19T14:41:25Z

Tested Ethereum Mainnet and POA Core. Looks great 👍

* The iex was not initiating due to this dependency

amandasposito added the wip label Dec 18, 2018

ghost assigned amandasposito Dec 18, 2018

ghost added the in progress label Dec 18, 2018

amandasposito force-pushed the ams-reward-value-in-tile branch from a4daa27 to 62db993 Compare December 18, 2018 14:01

acravenho reviewed Dec 18, 2018

View reviewed changes

acravenho suggested changes Dec 18, 2018

View reviewed changes

apps/block_scout_web/lib/block_scout_web/views/block_view.ex Outdated

def show_reward?(_), do: true

def formatted_reward(block_reward) do

{:ok, decimal} = Wei.dump(block_reward.reward)

This comment was marked as resolved.

Sign in to view

amandasposito force-pushed the ams-reward-value-in-tile branch from 62db993 to 9eb8519 Compare December 18, 2018 15:23

acravenho reviewed Dec 18, 2018

View reviewed changes

apps/block_scout_web/lib/block_scout_web/templates/block/overview.html.eex Outdated

<%= if show_reward?(@validator_reward) do %>

<dl class="row">

<dt class="col-sm-5 text-muted"><%= gettext "Validator Reward" %></dt>

This comment was marked as resolved.

Sign in to view

amandasposito force-pushed the ams-reward-value-in-tile branch from 9eb8519 to f006366 Compare December 18, 2018 17:17

amandasposito requested review from w-sanches, GustavoSantosFe and brwatanabe December 18, 2018 17:32

amandasposito added ready for review This PR is ready for reviews. and removed wip labels Dec 18, 2018

w-sanches reviewed Dec 18, 2018

View reviewed changes

apps/explorer/lib/explorer/chain/transaction.ex Outdated

@@ -612,4 +612,11 @@ defmodule Explorer.Chain.Transaction do

limit: 1

)

end

def block_hash_to_transactions(block_hash) do

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view

GustavoSantosFe approved these changes Dec 18, 2018

View reviewed changes

w-sanches reviewed Dec 18, 2018

View reviewed changes

amandasposito force-pushed the ams-reward-value-in-tile branch 5 times, most recently from ec08364 to 77864d6 Compare December 18, 2018 19:09

brwatanabe approved these changes Dec 18, 2018

View reviewed changes

amandasposito force-pushed the ams-reward-value-in-tile branch from 77864d6 to 67cfc24 Compare December 18, 2018 19:19

w-sanches approved these changes Dec 18, 2018

View reviewed changes

amandasposito force-pushed the ams-reward-value-in-tile branch 2 times, most recently from 01f6dce to dbc14d5 Compare December 19, 2018 14:16

acravenho approved these changes Dec 19, 2018

View reviewed changes

amandasposito added 3 commits December 19, 2018 13:07

Add reward value of a block in the tile and overview section

de35206

Add :dev to plug_cowboy dependency in explorer

6cb8f3f

* The iex was not initiating due to this dependency

Add gettext

c939b1d

amandasposito force-pushed the ams-reward-value-in-tile branch from dbc14d5 to c939b1d Compare December 19, 2018 15:08

amandasposito merged commit f0bde6a into master Dec 19, 2018

ghost removed the in progress label Dec 19, 2018

amandasposito deleted the ams-reward-value-in-tile branch December 19, 2018 15:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add reward value of a block in the tile and overview section. #1249

Add reward value of a block in the tile and overview section. #1249

amandasposito commented Dec 18, 2018 •

edited

coveralls commented Dec 18, 2018 •

edited

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

acravenho commented Dec 18, 2018

amandasposito commented Dec 19, 2018

acravenho commented Dec 19, 2018

Add reward value of a block in the tile and overview section. #1249

Add reward value of a block in the tile and overview section. #1249

Conversation

amandasposito commented Dec 18, 2018 • edited

Motivation

Changelog

Bug Fixes

coveralls commented Dec 18, 2018 • edited

Pull Request Test Coverage Report for Build ec16521a-ce23-4f65-9787-cd1aaad13d29

💛 - Coveralls

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

acravenho commented Dec 18, 2018

amandasposito commented Dec 19, 2018

acravenho commented Dec 19, 2018

amandasposito commented Dec 18, 2018 •

edited

coveralls commented Dec 18, 2018 •

edited