Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable usd value for an empty exchange rate #1492

Merged
merged 11 commits into from
Mar 5, 2019
Merged

Conversation

ayrat555
Copy link
Contributor

fixes #1431

Changelog

  • disable usd value for an empty exchange rate

@ghost ghost assigned ayrat555 Feb 27, 2019
@ghost ghost added the in progress label Feb 27, 2019
@ayrat555 ayrat555 requested review from zachdaniel and acravenho and removed request for zachdaniel February 27, 2019 09:39
@coveralls
Copy link

coveralls commented Feb 27, 2019

Pull Request Test Coverage Report for Build cbae1958-3ae3-4b57-a143-af91c42944c6

  • 2 of 3 (66.67%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.555%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/explorer/lib/explorer/exchange_rates/token.ex 0 1 0.0%
Totals Coverage Status
Change from base Build 3ce343ae-7cbd-4be9-aec3-78de7c898cac: 0.0%
Covered Lines: 4281
Relevant Lines: 5063

💛 - Coveralls

@vbaranov
Copy link
Member

vbaranov commented Mar 4, 2019

@ayrat555 please resolve merging conflicts

@ayrat555
Copy link
Contributor Author

ayrat555 commented Mar 4, 2019

@vbaranov done

@ghost ghost assigned vbaranov Mar 4, 2019
@vbaranov
Copy link
Member

vbaranov commented Mar 4, 2019

@ayrat555 Was not able to merge to master - many tests were failed. Please take a look when you will have a chance.

@ayrat555
Copy link
Contributor Author

ayrat555 commented Mar 5, 2019

@vbaranov I fixed all tests

@vbaranov vbaranov self-requested a review March 5, 2019 08:58
@vbaranov vbaranov merged commit 434b445 into master Mar 5, 2019
@ghost ghost removed the in progress label Mar 5, 2019
@vbaranov vbaranov deleted the ab-disable-usd-value branch March 5, 2019 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add large number support.
4 participants