Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove dropped/replaced transactions in pending transactions list #1496

Conversation

zachdaniel
Copy link
Contributor

@zachdaniel zachdaniel commented Feb 27, 2019

Resolves: #1488

Motivation

We only want to show truly pending transactions on the pending transactions page.

This also removes the pending transaction behavior for dropped/replaced transaction detail pages.

@ghost ghost assigned zachdaniel Feb 27, 2019
@ghost ghost added the in progress label Feb 27, 2019
@zachdaniel zachdaniel force-pushed the remove-dropped-replaced-transactions-from-pending-transaction-list branch 3 times, most recently from 21255a6 to 4a879db Compare February 27, 2019 20:43
@coveralls
Copy link

Pull Request Test Coverage Report for Build f0bf3385-4d54-4bad-8b2a-bfd5a64258b8

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 84.663%

Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/lib/block_scout_web/views/transaction_view.ex 1 93.55%
apps/explorer/lib/explorer/chain.ex 9 90.52%
Totals Coverage Status
Change from base Build 9fd3a554-733b-4ae2-9e07-c44fc41b9489: 0.02%
Covered Lines: 4256
Relevant Lines: 5027

💛 - Coveralls

@coveralls
Copy link

coveralls commented Feb 27, 2019

Pull Request Test Coverage Report for Build 7465c95f-0f8e-40bc-bc51-5c67924cfad0

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 84.848%

Files with Coverage Reduction New Missed Lines %
apps/indexer/lib/indexer/pending_transaction/fetcher.ex 1 73.08%
Totals Coverage Status
Change from base Build 5052dc7f-8d63-40eb-a201-7918152f975b: 0.0%
Covered Lines: 4267
Relevant Lines: 5029

💛 - Coveralls

@zachdaniel zachdaniel force-pushed the remove-dropped-replaced-transactions-from-pending-transaction-list branch from 4a879db to c861879 Compare February 28, 2019 16:05
@ghost ghost assigned vbaranov Mar 1, 2019
@vbaranov vbaranov self-requested a review March 1, 2019 17:24
@vbaranov vbaranov merged commit faf6752 into master Mar 1, 2019
@ghost ghost removed the in progress label Mar 1, 2019
@vbaranov vbaranov deleted the remove-dropped-replaced-transactions-from-pending-transaction-list branch March 1, 2019 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants