Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add incoming transactions count to contract view #1562

Merged
merged 4 commits into from Mar 14, 2019

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented Mar 14, 2019

Counting alll transactions take too much time. We need to implement some kind of cached counters to cache this value so the value is limited to 10_000 in the future

image1

image2

fixes #1450

Changelog

  • add incoming transactions count to contract view

@ghost ghost assigned ayrat555 Mar 14, 2019
@ghost ghost added the in progress label Mar 14, 2019
@coveralls
Copy link

coveralls commented Mar 14, 2019

Pull Request Test Coverage Report for Build 39de75c5-e606-463e-8e85-911d36d5c809

  • 7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 84.464%

Totals Coverage Status
Change from base Build bea9f6db-21d9-4fc3-9a03-d92e65164fe6: 0.2%
Covered Lines: 4295
Relevant Lines: 5085

💛 - Coveralls

@ayrat555 ayrat555 force-pushed the ab-add-incoming-transactions-count branch from b060d67 to 44ccb21 Compare March 14, 2019 12:15
@ayrat555 ayrat555 force-pushed the ab-add-incoming-transactions-count branch from 44ccb21 to 59b624a Compare March 14, 2019 12:17
@vbaranov vbaranov merged commit a121e21 into master Mar 14, 2019
@vbaranov vbaranov deleted the ab-add-incoming-transactions-count branch March 14, 2019 16:27
@ghost ghost removed the in progress label Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add incoming transaction count to contract pages
4 participants