feat: allow setting different configuration just for realtime fetcher #1567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
zachdaniel
force-pushed
the
realtime-separate-node-configuration
branch
from
daa312e
to
af88c51
Compare
zachdaniel
force-pushed
the
realtime-separate-node-configuration
branch
from
af88c51
to
75b558b
Compare
Pull Request Test Coverage Report for Build 7cf53e03-b0fd-4041-bccf-0995534c0728
💛 - Coveralls |
vbaranov
approved these changes
Mar 15, 2019
ayrat555
approved these changes
Mar 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1566
This allows a simple configuration to be set alongside other indexer configurations, which will just be merged with the entire configuration only for the realtime fetcher. This allows setting a dedicated node for the realtime fetcher.
There are a lot of downstream components called by the realtime fetcher, so we will definitely want to test this out in stg to make sure there are no unintended side effects.