Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not fetch burn address balance #1614

Merged
merged 3 commits into from
Mar 21, 2019
Merged

do not fetch burn address balance #1614

merged 3 commits into from
Mar 21, 2019

Conversation

ayrat555
Copy link
Contributor

fixes #1593

Changelog

  • do not fetch burn address balance

@ghost ghost assigned ayrat555 Mar 20, 2019
@ghost ghost added the in progress label Mar 20, 2019
@coveralls
Copy link

coveralls commented Mar 20, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build e7f890ab-9529-4231-9c4e-2625e7a75831

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 23 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-0.3%) to 81.484%
Files with Coverage Reduction New Missed Lines %
apps/indexer/lib/indexer/block/catchup/fetcher.ex 1 70.73%
apps/indexer/lib/indexer/memory/shrinkable.ex 1 50.0%
apps/indexer/lib/indexer/block/catchup/bound_interval_supervisor.ex 2 81.48%
apps/indexer/lib/indexer/sequence.ex 2 90.77%
apps/indexer/lib/indexer/bound_interval.ex 2 60.0%
apps/indexer/lib/indexer/token/fetcher.ex 3 64.29%
apps/indexer/lib/indexer/block/fetcher.ex 12 73.33%
Totals Coverage Status
Change from base Build 9348625e-cfd1-4ecf-8071-55bdb847fdbf: -0.3%
Covered Lines: 4216
Relevant Lines: 5174
💛 - Coveralls

@ghost ghost assigned vbaranov Mar 21, 2019
vbaranov
vbaranov requested changes Mar 21, 2019
View reviewed changes
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no changelog update

@vbaranov vbaranov self-requested a review March 21, 2019 10:38
@vbaranov vbaranov merged commit 03e2bcd into master Mar 21, 2019
@ghost ghost removed the in progress label Mar 21, 2019
@vbaranov vbaranov deleted the ab-do-not-fetch-burn-address-balance branch March 21, 2019 10:41
@ayrat555 ayrat555 mentioned this pull request Apr 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goodsoft goodsoft goodsoft approved these changes

@vbaranov vbaranov vbaranov approved these changes

@zachdaniel zachdaniel zachdaniel approved these changes

Assignees

@vbaranov vbaranov

@ayrat555 ayrat555

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing trie node error from 0x00... account tx's [geth/clique]
5 participants
@ayrat555 @coveralls @goodsoft @vbaranov @zachdaniel