Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.3.9 release (Mainnet-Staging) #1715

Merged
merged 117 commits into from
Apr 9, 2019
Merged

1.3.9 release (Mainnet-Staging) #1715

merged 117 commits into from
Apr 9, 2019

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented Apr 8, 2019

Features

  • #1662 - allow specifying number of optimization runs
  • #1654 - add decompiled code tab
  • #1661 - try to compile smart contract with the latest evm version
  • #1665 - Add contract verification RPC endpoint.

Fixes

  • #1669 - do not fail if multiple matching tokens are found
  • #1691 - decrease token metadata update interval
  • #1688 - do not fail if failure reason is atom
  • #1692 - exclude decompiled smart contract from encoding
  • #1684 - Discard child block with parent_hash not matching hash of imported block
  • #1699 - use seconds as transaction cache period measure
  • #1697 - fix failing in rpc if balance is empty
  • #1712 - do not set contract code from transaction input

ayrat555 and others added 30 commits March 22, 2019 12:11
@ayrat555
add transaction count cache
978af2d
@ayrat555
Merge branch 'master' into ab-transaction-count-cache
2ac3471
@ayrat555
use cache for estimated transaction count
8a58d4b
@ayrat555
Merge branch 'master' into ab-transaction-count-cache
11329d6
@ayrat555
fix tests
6360ecf
@ayrat555
fix credo
6727a8b
@ayrat555
Merge branch 'master' into ab-transaction-count-cache
6396362
@ayrat555
add CHANGELOG entry
fd08bc1
@ayrat555
Merge branch 'master' into ab-transaction-count-cache
c1cc0c9
@vbaranov
Merge branch 'master' into ab-transaction-count-cache
0235ec3
@ayrat555
add petersburg evm version
77b0441
@ayrat555
Merge branch 'master' into ab-transaction-count-cache
ab75da6
@ayrat555
add changelog entry
907adda
@ayrat555
fetch transaction period from env variables
a6c4dce
@vbaranov
Merge branch 'master' into ab-add-petersburg-evm-version
0c67eae
@ayrat555
set only hours in env var
62990e8
@ayrat555
fix dialyzer
dd9a083
@ayrat555
make tab visible if contract has any decompiled code
db5853c
@ayrat555
define evm versions in one place
2d99fb5
@ayrat555
use correct type for evm_version
53f0baf
@ayrat555
fix view test
905f86b
@ayrat555
add query to return decompiled contracts
ebf5bcf
@ayrat555
add decompiled contract tab endpoint
3b23756
@ayrat555
add a simple view that show single decomplid code entry
417a236
@zachdaniel
feat: add listcontracts endpoint
e694d14
@ayrat555
add decompiled contract tab
2e0a19f
@ayrat555
fix mobile dropdown menu
4cb49e0
@ayrat555
fix current selected tab for decompiled code
545a88b
@ayrat555
show multiple decompiled contracts
1e5a1a8
@ayrat555
add line break between decompiler version and decompiled code
22ecca0
goodsoft and others added 19 commits April 2, 2019 21:13
@goodsoft
Discard child block with parent_hash not matching hash of imported block
6450c3a 
Consider a root block `A`, old chain `-- B -- C` and new one `-- B' -- C'`.
Due to asynchronous nature of realtime fetcher it is possible for block
`B` to be imported _later_ than the entire chain `-- B' -- C'`.

In this case we should discard block `C'` and let it be refetched.
When that happens, block `B` gets discarded to make sure block `B'` gets
eventually fetched and the chain becomes consistent.
@goodsoft
Remove obsolete InvalidConsensus.Worker
0e15873 
This worker only handled one of invalid consensus cases, i.e. when a parent
block lost consensus, but the child one didn't.
Even then it worked only when all blocks are reliably and sequentially
imported (certainly not our case), and only once on indexer launch.

Now this particular case is covered by previous commit, and we don't need
this worker at all.
@goodsoft
Merge pull request #1684 from poanetwork/gs-fix-consensus-loss
313df94 
Discard child block with parent_hash not matching hash of imported block
@ayrat555
fix failing in rpc if balance is empty
dcbc541
@ayrat555
add CHANGELOG entry
3183aa6
@ayrat555
use seconds as period measure
c63d0d2
@ayrat555
add changelog entry
e17aaac
@zachdaniel
feat: verify contracts via an RPC endpoint
1f05f67
@zachdaniel
Merge pull request #1665 from poanetwork/verify-contracts-rpc
c634172 
Verify contracts rpc
@ayrat555
Merge branch 'master' into ab-fix-null-balance-in-rpc
24ea3ac
@ayrat555
use null value
f5f5b0f
@ayrat555
Merge branch 'master' into ab-use-seconds-to-update-transaction-cache
34bd1a5
@ayrat555
use literal nul
c8e6eb5
@ayrat555
Merge pull request #1697 from poanetwork/ab-fix-null-balance-in-rpc
f6bb5ed 
fix failing in rpc if balance is empty
@ayrat555
Merge branch 'master' into ab-use-seconds-to-update-transaction-cache
dd9ffd7
@ayrat555
Merge pull request #1699 from poanetwork/ab-use-seconds-to-update-tra…
42f8e72 
…nsaction-cache

use seconds as transaction cache period measure
@ayrat555
do not set contract code from transactio input
198ebcd
@ayrat555
Merge pull request #1712 from poanetwork/ab-do-not-set-contract-code-…
8248806 
…from-transaction-input

do not set contract code from transaction input
@ayrat555
update CHANGELOG
946a1d7
@ghost ghost assigned ayrat555 Apr 8, 2019
@ghost ghost added the in progress label Apr 8, 2019
@coveralls
Copy link

coveralls commented Apr 8, 2019 •
edited

Pull Request Test Coverage Report for Build f60d5f70-1764-48dc-9fd0-61d747f1a696

  • 163 of 199 (81.91%) changed or added relevant lines in 17 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 78.771%
Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/block_scout_web/lib/block_scout_web/views/address_view.ex 2 3 66.67%
apps/ethereum_jsonrpc/lib/ethereum_jsonrpc/contract.ex 0 1 0.0%
apps/explorer/lib/explorer/chain/import/runner/blocks.ex 14 15 93.33%
apps/explorer/lib/explorer/chain/smart_contract.ex 0 1 0.0%
apps/explorer/lib/explorer/smart_contract/verifier.ex 9 10 90.0%
apps/block_scout_web/lib/block_scout_web/controllers/address_decompiled_contract_controller.ex 0 6 0.0%
apps/explorer/lib/explorer/chain/transaction_count_cache.ex 32 38 84.21%
apps/block_scout_web/lib/block_scout_web/controllers/api/rpc/contract_controller.ex 37 44 84.09%
apps/explorer/lib/explorer/chain.ex 11 23 47.83%
Files with Coverage Reduction New Missed Lines %
apps/explorer/lib/explorer/chain.ex 1 86.26%
Totals Coverage Status
Change from base Build bf34e75b-b22c-4b35-9a68-2bcd1fce3f0d: 0.2%
Covered Lines: 4219
Relevant Lines: 5356
💛 - Coveralls

@ayrat555 ayrat555 merged commit 78a241f into staging-mainnet Apr 9, 2019
@ghost ghost removed the in progress label Apr 9, 2019
@ayrat555 ayrat555 deleted the 1.3.9-release branch April 9, 2019 08:46
This was referenced Apr 9, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ayrat555 ayrat555

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ayrat555 @coveralls @vbaranov @zachdaniel @goodsoft