Remove internal tx and token balance fetching from realtime fetcher #1724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
goodsoft
force-pushed
the
gs-async-realtime
branch
2 times, most recently
from
73c6d78
to
280b8e1
Compare
Pull Request Test Coverage Report for Build a23ddc33-a52c-4c99-a48d-3d39b40c5395
💛 - Coveralls |
|
This will actually help with RSK support as well. |
zachdaniel
approved these changes
Apr 10, 2019
Internal transactions and token balances are the slowest to fetch and import. We'd rather have almost instant import of almost all block-related info than frequent timeouts in realtime fetcher and handing blocks over to catchup fetcher which imports this data asynchronously anyway.
goodsoft
force-pushed
the
gs-async-realtime
branch
from
280b8e1
to
4512e6c
Compare
ayrat555
approved these changes
Apr 11, 2019
gabitoesmiapodo
added a commit
that referenced
this pull request
Apr 12, 2019
#1638-new-style-for-lukso-network * feature/#1476-add-styles-for-POSDAO-network: fix test remove inspect add line numbers change colors add CHANGELOG entry Remove internal tx and token balance fetching from realtime fetcher (#1724) fix empty block time change styles add test fix highlighting add CHANGELOG entry highlight decompiled source code Flatten indexer module hierarchy and supervisor tree (#1718)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roughly covers steps 5 and 6 from my refactoring plan.
Internal transactions and token balances are the slowest to fetch and import.
We'd rather have almost instant import of almost all block-related info than frequent timeouts in realtime fetcher and handing blocks over to catchup fetcher, which imports this data asynchronously anyway.
Checklist for your PR
CHANGELOG.mdwith this PR