Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add logs pagination in rpc api #1727

Merged
merged 7 commits into from
Apr 10, 2019
Merged

add logs pagination in rpc api #1727

merged 7 commits into from
Apr 10, 2019

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented Apr 10, 2019 •
edited by vbaranov
Loading

fixes #1674

Changelog

  • add logs pagination in rpc api:

next_page_params appears in the case of pagination

Example:

{"txhash":"0x0c61db4e3e40eb58fe9378c1ed7a611205ca8d49fb87f3f153051ccaa9b40147","module":"transaction","index":57,"action":"gettxinfo"}

@ghost ghost assigned ayrat555 Apr 10, 2019
@ghost ghost added the in progress label Apr 10, 2019
@coveralls
Copy link

coveralls commented Apr 10, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 8700627c-3218-4d1f-8e7b-c063367fae27

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 83.016%
Totals Coverage Status
Change from base Build e061fad8-3a9a-4db4-ab15-535b23e2052f: 0.006%
Covered Lines: 4448
Relevant Lines: 5358
💛 - Coveralls

@ayrat555 ayrat555 changed the title [WIP] add logs pagination in rpc api add logs pagination in rpc api Apr 10, 2019
@ayrat555 ayrat555 merged commit a432fb9 into master Apr 10, 2019
@ghost ghost removed the in progress label Apr 10, 2019
@ayrat555 ayrat555 deleted the ab-logs-pagination branch April 10, 2019 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goodsoft goodsoft goodsoft approved these changes

@saneery saneery saneery approved these changes

@zachdaniel zachdaniel Awaiting requested review from zachdaniel

Assignees

@ayrat555 ayrat555

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not all logs in api are returned for a transaction
4 participants
@ayrat555 @coveralls @goodsoft @saneery