Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Fix) Update telegram link #1749

Merged
merged 3 commits into from
Apr 15, 2019
Merged

(Fix) Update telegram link #1749

merged 3 commits into from
Apr 15, 2019

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Apr 14, 2019 •
edited
Loading

Relates to #1772

Motivation

The link in the footer is to unsupported telegram POA chatbox.

Changelog

  • Replace the link with the official POA announcements tg channel link

Checklist for your PR

  • I added an entry to CHANGELOG.md with this PR
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • I checked whether I should update the docs and did so if necessary

@ghost ghost assigned vbaranov Apr 14, 2019
@ghost ghost added the in progress label Apr 14, 2019
@vbaranov vbaranov added ready for review This PR is ready for reviews. and removed in progress labels Apr 14, 2019
@coveralls
Copy link

coveralls commented Apr 14, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 7bdf9fd9-3c3c-4820-8dff-54fdc2dfa74b

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 83.166%
Files with Coverage Reduction New Missed Lines %
apps/ethereum_jsonrpc/test/support/ethereum_jsonrpc/web_socket/case/mox.ex 5 66.67%
Totals Coverage Status
Change from base Build 61bf2c7a-7d58-435e-ba02-9ebf2c044868: -0.3%
Covered Lines: 4387
Relevant Lines: 5275
💛 - Coveralls

ayrat555
ayrat555 reviewed Apr 15, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@ghost ghost added the in progress label Apr 15, 2019
@vbaranov vbaranov merged commit 9ab7d34 into master Apr 15, 2019
@ghost ghost removed the in progress label Apr 15, 2019
@vbaranov vbaranov deleted the telegram-link-update branch April 25, 2019 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goodsoft goodsoft goodsoft approved these changes

@ayrat555 ayrat555 ayrat555 approved these changes

@saneery saneery saneery approved these changes

@zachdaniel zachdaniel Awaiting requested review from zachdaniel

Assignees

@vbaranov vbaranov

Labels
ready for review This PR is ready for reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vbaranov @coveralls @goodsoft @ayrat555 @saneery