Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make block size field nullable #1830

Merged
merged 2 commits into from
Apr 24, 2019
Merged

Make block size field nullable #1830

merged 2 commits into from
Apr 24, 2019

Conversation

goodsoft
Copy link
Contributor

@goodsoft goodsoft commented Apr 24, 2019 •
edited
Loading

Uncle block API returns null values for block size, and we need to properly store them in the database.

Checklist for your PR

  • I added an entry to CHANGELOG.md with this PR
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • I checked whether I should update the docs and did so if necessary

@goodsoft
Make block size field nullable
5512531 
Uncle block API returns null values for block size, and we need to
properly store them in the database.
@ghost ghost assigned goodsoft Apr 24, 2019
@ghost ghost added the in progress label Apr 24, 2019
@coveralls
Copy link

coveralls commented Apr 24, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 99dc3587-2b43-441c-b1af-b756928f20ef

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 82.304%
Totals Coverage Status
Change from base Build f83ed4ab-38d8-446d-b309-6bf98c69d840: 0.1%
Covered Lines: 4451
Relevant Lines: 5408
💛 - Coveralls

@goodsoft goodsoft added ready for review This PR is ready for reviews. and removed in progress labels Apr 24, 2019
@vbaranov vbaranov merged commit a3f91a7 into master Apr 24, 2019
@vbaranov vbaranov deleted the gs-fix-null-block-size branch April 24, 2019 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbaranov vbaranov vbaranov approved these changes

@zachdaniel zachdaniel zachdaniel approved these changes

@ayrat555 ayrat555 Awaiting requested review from ayrat555

Assignees

@goodsoft goodsoft

Labels
ready for review This PR is ready for reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@goodsoft @coveralls @vbaranov @zachdaniel