Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Feature) New pages for POSDAO network #1853

Merged

Conversation

gabitoesmiapodo
Copy link
Contributor

Depends heavily on #1807 being reviewed / approved / merged first.

Closes #1476

Motivation

I'm not sure about the differences present on https://invis.io/YPQNPDTW4ZB, and I would need the Zeplin files anyway.

  • Local configuration is as this:
export ETHEREUM_JSONRPC_VARIANT=ganache
export ETHEREUM_JSONRPC_HTTP_URL=http://127.0.0.1:8545
export ETHEREUM_JSONRPC_TRACE_URL=http://127.0.0.1:8545
export ETHEREUM_JSONRPC_WS_URL=ws://127.0.0.1:8545
export COIN=POA
export NETWORK=POA
export LOGO=/images/posdao_logo.png
export LOGO_FOOTER=/images/posdao_logo_footer.png
  • You can get to the new sections / components by doing:
  • The new Stakes section can be accessed using the "Stakes" dropdown on the header.
  • Validators should show:

"Login with Metamask"
"Empty content" component
Clicking the "Become Candidate" button shows related modal
Clicking the "Remove my pool" button shows warning modal

  • Active Pools should show:

Active pools list, including banned items
Account address above
Clicking the copy button shows success modal
Clicking the "Move Stakes" button shows error modal
Clicking the "Withdraw" button shows related modal
Clicking the "Stake" button shows related modal
Clicking the validator link button shows related modal

  • Inactive Pools shows an extra checkbox besides the title.

Changelog

Enhancements

New styles for POSDAO Network

Incompatible Changes

I don't think so.

Valentin and others added 6 commits April 24, 2019 00:52
…-pages-for-POSDAO-network-

* feature/new-theming-capabilites:
  (update) internationalization files
  (fix) tooltip color
  (update) address button icon
  (fix) transaction color
  (fix) blocks margin
  update changelog
  update gettext
  handle case when total supply is nil
  Update CHANGELOG
  --f -> -f
  update changelog
  Update CHANGELOG
  block counter calculate only consensus block
  Add --f flag to clear_build.sh script delete static folder
@ghost ghost assigned saneery Apr 27, 2019
@coveralls
Copy link

coveralls commented Apr 27, 2019

Pull Request Test Coverage Report for Build 5d3acf86-6424-460b-bf3d-60c62cb51e5c

  • 1 of 10 (10.0%) changed or added relevant lines in 5 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 82.11%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/ethereum_jsonrpc/lib/ethereum_jsonrpc/encoder.ex 1 2 50.0%
apps/block_scout_web/lib/block_scout_web/controllers/active_pools_controller.ex 0 2 0.0%
apps/block_scout_web/lib/block_scout_web/controllers/inactive_pools_controller.ex 0 2 0.0%
apps/block_scout_web/lib/block_scout_web/controllers/stakes_controller.ex 0 2 0.0%
apps/block_scout_web/lib/block_scout_web/controllers/validators_controller.ex 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
apps/indexer/lib/indexer/block/catchup/bound_interval_supervisor.ex 3 85.19%
Totals Coverage Status
Change from base Build 693c522e-8135-46f8-9ffb-78e30c11dbbf: -0.2%
Covered Lines: 4475
Relevant Lines: 5450

💛 - Coveralls

Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabitoesmiapodo

Screenshot 2019-04-29 at 13 14 50

Screenshot 2019-04-29 at 13 17 19

  1. Blocks on the main page have different height

@pashagonchar please review also. Below are the screenshots from the app built from this PR:

Screenshot 2019-04-29 at 13 16 49
Screenshot 2019-04-29 at 13 16 42
Screenshot 2019-04-29 at 13 16 36
Screenshot 2019-04-29 at 13 15 47

screencapture-localhost-4000-active-pools-2019-04-29-13_16_17
screencapture-localhost-4000-validators-2019-04-29-13_16_03
screencapture-localhost-4000-tx-0x11e1979e503a20674164e9b73e3010c44d015c0882cc154c37be5c955ce6b87f-token-transfers-2019-04-29-13_15_19
screencapture-localhost-4000-blocks-8420120-transactions-2019-04-29-13_14_28
screencapture-localhost-4000-2019-04-29-13_14_14

* master:
  Fix mix format test
  add cache for block counter
@gabitoesmiapodo
Copy link
Contributor Author

@vbaranov

Are those old screenshots (I mean, previous to the new-theming-capabilites -> master merging)?

Most or all of those issues should be fixed already.

Also, I don't understand what item number 2 means.

@vbaranov
Copy link
Member

Also, I don't understand what item number 2 means.

When you on the "... pools" tab it should be another header name for 1st column

@gabitoesmiapodo
Copy link
Contributor Author

@vbaranov

Oh, I see now.

I'll change it, no problem, but please keep in mind that all of this is still missing all of the business logic (it's mostly presentational / static code).

Which also begs the question of who will add that logic and when will that be done (#1476 (comment))

@gabitoesmiapodo
Copy link
Contributor Author

@vbaranov

  • Fixed the "Pools" text issue.
  • The rest should be fixed as well.

@vbaranov vbaranov self-requested a review April 29, 2019 20:23
@vbaranov
Copy link
Member

@gabitoesmiapodo tnx. I will merge the current state to not block the logic creation for embedded dapp by @saneery . @pashagonchar if there will be some corrections let's create a separate issue for Gabriel.

@vbaranov vbaranov merged commit 900dfbe into production-posdao Apr 29, 2019
goodsoft pushed a commit that referenced this pull request Aug 12, 2019
Co-Authored-By: maxgrapps <maxgrapps@gmail.com>
goodsoft pushed a commit that referenced this pull request Aug 12, 2019
Co-Authored-By: maxgrapps <maxgrapps@gmail.com>
goodsoft pushed a commit that referenced this pull request Aug 14, 2019
Co-Authored-By: maxgrapps <maxgrapps@gmail.com>
goodsoft pushed a commit that referenced this pull request Aug 14, 2019
Co-Authored-By: maxgrapps <maxgrapps@gmail.com>
goodsoft pushed a commit that referenced this pull request Aug 14, 2019
Co-Authored-By: maxgrapps <maxgrapps@gmail.com>
goodsoft pushed a commit that referenced this pull request Aug 15, 2019
Co-Authored-By: maxgrapps <maxgrapps@gmail.com>
goodsoft pushed a commit that referenced this pull request Aug 20, 2019
Co-Authored-By: maxgrapps <maxgrapps@gmail.com>
goodsoft pushed a commit that referenced this pull request Aug 22, 2019
Co-Authored-By: maxgrapps <maxgrapps@gmail.com>
goodsoft pushed a commit that referenced this pull request Aug 22, 2019
Co-Authored-By: maxgrapps <maxgrapps@gmail.com>
goodsoft pushed a commit that referenced this pull request Aug 24, 2019
Co-Authored-By: maxgrapps <maxgrapps@gmail.com>
goodsoft pushed a commit that referenced this pull request Aug 24, 2019
Co-Authored-By: maxgrapps <maxgrapps@gmail.com>
goodsoft pushed a commit that referenced this pull request Aug 28, 2019
Co-Authored-By: maxgrapps <maxgrapps@gmail.com>
goodsoft pushed a commit that referenced this pull request Aug 28, 2019
Co-Authored-By: maxgrapps <maxgrapps@gmail.com>
goodsoft pushed a commit that referenced this pull request Sep 3, 2019
Co-Authored-By: maxgrapps <maxgrapps@gmail.com>
goodsoft pushed a commit that referenced this pull request Sep 3, 2019
Co-Authored-By: maxgrapps <maxgrapps@gmail.com>
liberumed pushed a commit that referenced this pull request Sep 27, 2019
Co-Authored-By: maxgrapps <maxgrapps@gmail.com>
liberumed pushed a commit that referenced this pull request Sep 27, 2019
Co-Authored-By: maxgrapps <maxgrapps@gmail.com>
liberumed pushed a commit that referenced this pull request Oct 16, 2019
Co-Authored-By: maxgrapps <maxgrapps@gmail.com>
liberumed pushed a commit that referenced this pull request Oct 16, 2019
Co-Authored-By: maxgrapps <maxgrapps@gmail.com>
liberumed pushed a commit that referenced this pull request Oct 16, 2019
Co-Authored-By: maxgrapps <maxgrapps@gmail.com>
liberumed pushed a commit that referenced this pull request Oct 16, 2019
Co-Authored-By: maxgrapps <maxgrapps@gmail.com>
liberumed pushed a commit that referenced this pull request Oct 21, 2019
Co-Authored-By: maxgrapps <maxgrapps@gmail.com>
vbaranov pushed a commit that referenced this pull request Sep 9, 2020
Co-Authored-By: maxgrapps <maxgrapps@gmail.com>
vbaranov pushed a commit that referenced this pull request Sep 11, 2020
Co-Authored-By: maxgrapps <maxgrapps@gmail.com>
vbaranov pushed a commit that referenced this pull request Sep 14, 2020
Co-Authored-By: maxgrapps <maxgrapps@gmail.com>
vbaranov pushed a commit that referenced this pull request Oct 1, 2020
Co-Authored-By: maxgrapps <maxgrapps@gmail.com>
vbaranov pushed a commit that referenced this pull request Oct 2, 2020
Co-Authored-By: maxgrapps <maxgrapps@gmail.com>
vbaranov pushed a commit that referenced this pull request Oct 12, 2020
Co-Authored-By: maxgrapps <maxgrapps@gmail.com>
vbaranov pushed a commit that referenced this pull request Oct 15, 2020
Co-Authored-By: maxgrapps <maxgrapps@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants