Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: logs list endpoint performance #1868

Merged
merged 2 commits into from
May 1, 2019
Merged

fix: logs list endpoint performance #1868

merged 2 commits into from
May 1, 2019

Conversation

zachdaniel
Copy link
Contributor

@zachdaniel zachdaniel commented Apr 30, 2019

Resolves #1858

Changelog

Bug Fixes

  • Speed up the query for listing logs for the RPC API.

Testing the query manually against the stg database showed that this query returns in a nominal amount of time and its original version did not return at all, causing the request to time out resulting in a cloudflare error.

  • I added an entry to CHANGELOG.md with this PR
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • I checked whether I should update the docs and did so if necessary

(there isn't really a reasonable test to add here)

@ghost ghost assigned zachdaniel Apr 30, 2019
@ghost ghost added the in progress label Apr 30, 2019
@coveralls
Copy link

coveralls commented Apr 30, 2019

Pull Request Test Coverage Report for Build a736ca43-3909-44b5-aecd-b09197b6c45c

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 82.252%

Totals Coverage Status
Change from base Build 8db8a423-14ab-4243-ae9c-016c8b75fba4: 0.02%
Covered Lines: 4477
Relevant Lines: 5443

💛 - Coveralls

@vbaranov vbaranov requested review from goodsoft and saneery May 1, 2019 08:19
@ghost ghost assigned vbaranov May 1, 2019
@vbaranov vbaranov merged commit fbf0782 into master May 1, 2019
@ghost ghost removed the in progress label May 1, 2019
@vbaranov vbaranov deleted the list-logs-performance branch May 12, 2019 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getLogs blockscout API does not work
5 participants