remove temporary worker modules #1892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Pull Request Test Coverage Report for Build 66ae22e0-ec3b-4947-8f2c-6704677e5a41
💛 - Coveralls |
|
#1797 may be related to these workers. |
|
@acravenho it doesn't seem related because these workers do not update internal transactions. They only refetch code and refetch blocks without changing anything |
ayrat555
requested review from
vbaranov,
goodsoft,
zachdaniel and
saneery
and removed request for
goodsoft
goodsoft
approved these changes
May 7, 2019
saneery
approved these changes
May 7, 2019
vbaranov
approved these changes
May 7, 2019
zachdaniel
approved these changes
May 7, 2019
|
@ayrat555, I think you also should remove entries about these workers from the readme |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR removes two temporary worker modules related to #1389 and #1438
Looking into logs these workers have finished their execution. They execute pretty heavy queires so removing them is desirable
Changelog