Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix reorgs, uncles pagination #1905

Merged
merged 7 commits into from
May 9, 2019
Merged

fix reorgs, uncles pagination #1905

merged 7 commits into from
May 9, 2019

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented May 7, 2019 •
edited by vbaranov
Loading

Relates to #1886

@ghost ghost assigned ayrat555 May 7, 2019
@ghost ghost added the in progress label May 7, 2019
@coveralls
Copy link

coveralls commented May 7, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 1556172b-fb4f-452d-9cb4-6c3c7affc463

  • 4 of 6 (66.67%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.1%) to 81.77%
Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/block_scout_web/lib/block_scout_web/controllers/block_controller.ex 4 6 66.67%
Files with Coverage Reduction New Missed Lines %
apps/indexer/lib/indexer/fetcher/token.ex 1 78.57%
apps/indexer/lib/indexer/fetcher/token_balance.ex 2 87.1%
apps/indexer/lib/indexer/block/fetcher.ex 3 86.57%
Totals Coverage Status
Change from base Build c86f3b22-f56d-4936-ba55-b4a2d5f5d40d: -0.1%
Covered Lines: 4638
Relevant Lines: 5672
💛 - Coveralls

@vbaranov
Copy link
Member

vbaranov commented May 8, 2019

@ayrat555 please add CHANGELOG entry 👮

@ayrat555 ayrat555 merged commit 762d53b into master May 9, 2019
@ayrat555 ayrat555 deleted the ab-fix-reorg-uncles-pagination branch May 9, 2019 08:52
@ghost ghost removed the in progress label May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbaranov vbaranov vbaranov approved these changes

@zachdaniel zachdaniel zachdaniel approved these changes

@goodsoft goodsoft Awaiting requested review from goodsoft

@saneery saneery Awaiting requested review from saneery

Assignees

@ayrat555 ayrat555

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ayrat555 @coveralls @vbaranov @zachdaniel