Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check the presence of overlap[i] object #1937

Merged
merged 2 commits into from
May 14, 2019
Merged

Check the presence of overlap[i] object #1937

merged 2 commits into from
May 14, 2019

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented May 13, 2019 •
edited
Loading

Fixes #1298

Checklist for your PR

Check the presence of overlap[i] object before retrieving properties from it

  • I added an entry to CHANGELOG.md with this PR
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • I checked whether I should update the docs and did so if necessary

@ghost ghost assigned vbaranov May 13, 2019
@ghost ghost added the in progress label May 13, 2019
@vbaranov vbaranov changed the title Check presence of overlap[i] Check the presence of overlap[i] object May 13, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5de7bd47-5123-4273-bb02-33b59a6333fb

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.804%
Totals Coverage Status
Change from base Build 782d44e1-3ce0-4d82-befd-9964118470b6: 0.0%
Covered Lines: 4644
Relevant Lines: 5677
💛 - Coveralls

@vbaranov vbaranov removed the request for review from goodsoft May 13, 2019 14:12
@vbaranov vbaranov merged commit 2baad80 into master May 14, 2019
@vbaranov vbaranov deleted the check-element-in-the-list branch May 14, 2019 08:42
@ghost ghost removed the in progress label May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachdaniel zachdaniel zachdaniel approved these changes

@saneery saneery saneery approved these changes

@pasqu4le pasqu4le pasqu4le approved these changes

@ayrat555 ayrat555 Awaiting requested review from ayrat555

Assignees

@vbaranov vbaranov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read property of id of undefined
5 participants
@vbaranov @coveralls @zachdaniel @saneery @pasqu4le