Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add on demand fetching and stale attr to rpc #1941

Merged
merged 1 commit into from
May 14, 2019

Conversation

zachdaniel
Copy link
Contributor

@zachdaniel zachdaniel commented May 13, 2019

Resolves #1891

Motivation

We want to trigger a balance fetch on any stale balances when they are retrieved via the API, not only when they are viewed in the UI. So that consumers would know, I added an attribute to the response called "stale" that is set to true when we have determined that the balance is old and is worth checking again. This doesn't mean that the balance is wrong (it will usually be right), it just means that we haven't seen an update for it in the last 24 hours, so we're going to check it again.

Changelog

Enhancements

  • Fetch coin balance on demand for API requests.

    • I added an entry to CHANGELOG.md with this PR
    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
    • I checked whether I should update the docs and did so if necessary

@ghost ghost assigned zachdaniel May 13, 2019
@ghost ghost added the in progress label May 13, 2019
@zachdaniel zachdaniel force-pushed the on-demand-balances-from-api branch from aae60bd to 9ae834d Compare May 13, 2019 17:31
@zachdaniel zachdaniel force-pushed the on-demand-balances-from-api branch from 9ae834d to bbbb8b7 Compare May 13, 2019 17:35
@coveralls
Copy link

coveralls commented May 13, 2019

Pull Request Test Coverage Report for Build 44b9cfc1-d85a-45e9-9958-37c6e1262608

  • 12 of 12 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 81.893%

Totals Coverage Status
Change from base Build 782d44e1-3ce0-4d82-befd-9964118470b6: 0.09%
Covered Lines: 4654
Relevant Lines: 5683

💛 - Coveralls

@vbaranov vbaranov merged commit f48e2c7 into master May 14, 2019
@vbaranov vbaranov deleted the on-demand-balances-from-api branch May 28, 2019 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

trigger on demand balance fetcher by API requests
5 participants