event logs tab #1956
event logs tab #1956
Conversation
ghost
assigned 
Pull Request Test Coverage Report for Build accb8a55-8ae1-4674-8863-ca3a610a9dbb
💛 - Coveralls |
| <%= render BlockScoutWeb.CommonComponentsView, "_pagination_container.html", position: "top", cur_page_number: "1", show_pagination_limit: true, next_page_path: @next_page_url %> | ||
| <% end %> | ||
|
|
||
| <%= if !@next_page_url do %> |
There was a problem hiding this comment.
This could just be an else
|
|
||
| query | ||
| |> Repo.all() | ||
| |> Enum.take(paging_options.page_size) |
There was a problem hiding this comment.
Isn't this unnecessary, given that the query already sets this limit?
Also 2 nitpicks:
queryis only used here, it could be directly piped intoRepo.allwithout an assignment- I may be wrong, but it seems several
Explorer.Chain.*modules define a specific function to generate this kind of queries, e.g. likeCoinBalance
|
Is search function a part of the PR or will it be implemented separately? |
|
@igorbarinov what do you mean by search functions? should we able to search by the transaction? |
|
Should a be a search box so developers can search for events within smart contract logs across all transactions. "[..] and a search function. Users should be able to search for event logs by topic across the full blockchain." In the provided example there are > 204,404 transfers in the smart contract and it will be convinient to have a search function for it. |
|
I will merge this. @ayrat555 please add search functionality in a separate PR. |
a part of #1927
Changelog