Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block/tx not found errors pages #2010

Merged
merged 18 commits into from
May 24, 2019
Merged

Block/tx not found errors pages #2010

merged 18 commits into from
May 24, 2019

Conversation

vbaranov
Copy link
Member

A part of #1747

Changelog

  • new pages for "block/tx not found" case and corresponding assets for all chains

    • I added an entry to CHANGELOG.md with this PR
    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
    • I checked whether I should update the docs and did so if necessary

@vbaranov vbaranov added the wip label May 23, 2019
@coveralls
Copy link

coveralls commented May 23, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build d04aa6ad-ec9c-4356-a76b-f1897b5e3a9f

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.065%
Totals Coverage Status
Change from base Build c3fa8066-7c81-4618-9e6b-0eac5c047df7: 0.0%
Covered Lines: 4718
Relevant Lines: 5820
💛 - Coveralls

@vbaranov vbaranov added ready for review This PR is ready for reviews. and removed wip labels May 23, 2019
zachdaniel
zachdaniel approved these changes May 23, 2019
View reviewed changes
Copy link
Contributor

@zachdaniel zachdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't really say much about the styling myself, but everything else looks good :)

@ayrat555
Copy link
Contributor

it would be great if a screenshot was attached

@vbaranov
Copy link
Member Author

it would be great if a screenshot was attached

@ayrat555 the screenshots are in the original issue and in the preliminary PR #2005

@vbaranov vbaranov merged commit 042cc8f into master May 24, 2019
@vbaranov vbaranov deleted the errors branch May 24, 2019 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachdaniel zachdaniel zachdaniel approved these changes

@ayrat555 ayrat555 ayrat555 approved these changes

@pasqu4le pasqu4le pasqu4le approved these changes

@saneery saneery Awaiting requested review from saneery

Assignees
No one assigned
Labels
ready for review This PR is ready for reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vbaranov @coveralls @ayrat555 @zachdaniel @pasqu4le @maxgrapps