Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PORT env variable in dev config #2018

Merged
merged 2 commits into from
May 27, 2019
Merged

Use PORT env variable in dev config #2018

merged 2 commits into from
May 27, 2019

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented May 24, 2019 •
edited
Loading

Closes #2004

Checklist for your PR

  • I added an entry to CHANGELOG.md with this PR
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • I checked whether I should update the docs and did so if necessary

@vbaranov vbaranov added the ready for review This PR is ready for reviews. label May 24, 2019
@coveralls
Copy link

coveralls commented May 24, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build ce07b3b6-1e57-43e9-aa3c-f5c12da01e7a

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 81.271%
Totals Coverage Status
Change from base Build 3876cbf0-b907-4b01-9fe2-e85b648e7ba1: 0.1%
Covered Lines: 4730
Relevant Lines: 5820
💛 - Coveralls

@vbaranov vbaranov merged commit c100c48 into master May 27, 2019
@vbaranov vbaranov deleted the port-for-dev branch May 27, 2019 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayrat555 ayrat555 ayrat555 approved these changes

@saneery saneery saneery approved these changes

@pasqu4le pasqu4le pasqu4le approved these changes

@zachdaniel zachdaniel Awaiting requested review from zachdaniel

Assignees
No one assigned
Labels
ready for review This PR is ready for reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support of PORT env variable for dev environment
5 participants
@vbaranov @coveralls @ayrat555 @saneery @pasqu4le