Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) txs errors color #2025

Merged
merged 5 commits into from
May 28, 2019
Merged

(fix) txs errors color #2025

merged 5 commits into from
May 28, 2019

Conversation

gabitoesmiapodo
Copy link
Contributor

Closes #1934

Motivation

To add a new color to display transactions' errors.

Changelog

Bug Fixes

  • Added a new color to display transactions' errors.

Checklist for your PR

  • I added an entry to CHANGELOG.md with this PR
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • I checked whether I should update the docs and did so if necessary

@coveralls
Copy link

coveralls commented May 24, 2019

Pull Request Test Coverage Report for Build c36481b9-765c-449f-9265-8f2e8e20f61d

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 68 unchanged lines in 16 files lost coverage.
  • Overall coverage decreased (-1.2%) to 80.069%

Files with Coverage Reduction New Missed Lines %
apps/indexer/lib/indexer/transform/addresses.ex 1 79.17%
apps/ethereum_jsonrpc/lib/ethereum_jsonrpc/geth/calls.ex 1 0.0%
apps/ethereum_jsonrpc/test/support/ethereum_jsonrpc/case/geth/mox.ex 1 0.0%
apps/indexer/lib/indexer/fetcher/internal_transaction.ex 1 56.9%
apps/ethereum_jsonrpc/test/support/ethereum_jsonrpc/case/geth/http_websocket.ex 1 0.0%
apps/indexer/lib/indexer/fetcher/token.ex 1 78.57%
apps/ethereum_jsonrpc/lib/ethereum_jsonrpc.ex 2 83.33%
apps/indexer/lib/indexer/fetcher/token_balance.ex 2 87.1%
apps/indexer/lib/indexer/block/catchup/fetcher.ex 4 69.23%
apps/ethereum_jsonrpc/lib/ethereum_jsonrpc/fetched_code.ex 4 0.0%
Totals Coverage Status
Change from base Build ae1c527a-460d-4beb-a514-abe8b88d1fe8: -1.2%
Covered Lines: 4660
Relevant Lines: 5820

💛 - Coveralls

@vbaranov vbaranov self-requested a review May 25, 2019 05:41
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabitoesmiapodo

Screenshot 2019-05-25 at 08 41 18

<span class="tile-status-label ml-2 ml-md-0" data-test="transaction_status">
        Error: (Awaiting internal transactions for reason)
      </span>

* master:
  Update CHANGELOG.md
  Update CHANGELOG.md
  Update _dropdown.scss
  Update _dai_variables.scss
  Update CHANGELOG.md
  Update _dai_variables.scss
  Update dai_logo.svg
  (update) changelog
  (fix) wrong tabs behavior
  (update) changelog
  (update) language files
  (fix) Missing tx hashes
  Add CHANGELOG entry
  Use PORT env variable in dev config

# Conflicts:
#	CHANGELOG.md
@gabitoesmiapodo
Copy link
Contributor Author

@vbaranov

Fixed it.

This one can be tricky, because each error has a different CSS class name, so it would necessary to create a rule for each error. I created a "catch all" CSS rule that should solve this problem, but YMMV.

@vbaranov vbaranov merged commit fe092f2 into master May 28, 2019
@vbaranov vbaranov deleted the fix/#1934-txs-with-errors-design branch May 28, 2019 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Txs with errors design
3 participants