Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Feature) New network selector #2044

Merged
merged 35 commits into from
Jun 27, 2019
Merged

(Feature) New network selector #2044

merged 35 commits into from
Jun 27, 2019

Conversation

gabitoesmiapodo
Copy link
Contributor

Closes #2038

Motivation

There's a new design which includes new functionality for the network selection component.

Zeplin design can be found at https://zpl.io/a7WEMEq

Besides the already functioning network selection, this implementation only implements the static elements. Extra logic should be added to make this fully work.

Correct colors should be configured later for each particular theme.

Some screenshots

Screen Shot 2019-05-28 at 14 09 44
Screen Shot 2019-05-28 at 14 09 51
Screen Shot 2019-05-28 at 14 09 57
Screen Shot 2019-05-28 at 14 10 15
Screen Shot 2019-05-28 at 14 10 45

Changelog

Enhancements

  • New network selection component.

Checklist for your PR

  • I added an entry to CHANGELOG.md with this PR
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • I checked whether I should update the docs and did so if necessary

@gabitoesmiapodo
(add) base elements for new network selector
c11d4ef
@gabitoesmiapodo
(add) new network selector behaviours
239b5ac
@gabitoesmiapodo
Merge branch 'master' into feature/#2038-new-network-selector
493a46c 
* master: (21 commits)
  (update) changelog
  (fix) added style for more types of errors
  make token inventory async
  fix transaction internal transaction controller tests
  fix gettext
  make transacion internal transaction async
  (update) changelog
  (fix) txs errors color
  fix block transaction tests
  fix gettext
  make block transaction async
  fix gettext
  fix transaction token transfer tests
  add transaction token transfer tab async
  fix credo, gettext
  fix transaction log tests
  make transaction logs tab async
  fix: fix to/from filters on tx list pages
  fix address_token_controller tests
  make logs loading async
  ...
@gabitoesmiapodo gabitoesmiapodo self-assigned this May 28, 2019
@gabitoesmiapodo
(update) changelog
094b46f
@gabitoesmiapodo
(update) internationalization
8ae7e32
@gabitoesmiapodo
Merge branch 'master' into feature/#2038-new-network-selector
79b450e 
* master: (28 commits)
  test issue
  test issues
  test issues
  test fixes
  Update CHANGELOG.md
  Update _verify_other_explorers.scss
  Fix gettext
  Fix templates
  disable verify in ohter explorersby default
  Verify in other explorers for all addresses/txs
  Update explorers links
  fix gettext
  Update _verify_other_explorers.html.eex
  Update CHANGELOG.md
  Update CHANGELOG.md
  Update _verify_other_explorers.scss
  Update _verify_other_explorers.html.eex
  Add files via upload
  Remove unused function clause
  trimmed verification link
  ...
@coveralls
Copy link

coveralls commented May 28, 2019 •
edited

Pull Request Test Coverage Report for Build 61f97ea9-ac95-4e08-97e0-62ff50887547

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 81.079%
Totals Coverage Status
Change from base Build cf94d4ac-5c9f-4013-a9a2-b366239b0b99: 0.05%
Covered Lines: 5108
Relevant Lines: 6300
💛 - Coveralls

@vbaranov
Copy link
Member

vbaranov commented Jun 3, 2019

@gabitoesmiapodo could you please resolve merging conflicts?

@gabitoesmiapodo
Merge branch 'master' into feature/#2038-new-network-selector
f7d68bf 
* master: (79 commits)
  fix CHANGELOG
  Update overview.html.eex
  Update CHANGELOG.md
  ui issues
  Update CHANGELOG.md
  blockscout theme new logo
  Add files via upload
  new logo for blockscout theme
  Update CHANGELOG.md
  blockscout theme
  (update) changelog
  (update) internationalization files
  (fix) commented out %> tag was showing
  (fix) missing checkmarks
  update CHANGELOG with PR 2070
  Reduce max_concurrency of BlocksTransactionsMismatch
  Add CHANGELOG entry and add 1.3.15 changelog
  Docsify setup
  Add docs folder for docsify integration
  stop click twice
  ...

# Conflicts:
#	CHANGELOG.md
#	apps/block_scout_web/assets/css/app.scss
#	apps/block_scout_web/lib/block_scout_web/templates/layout/_topnav.html.eex
#	apps/block_scout_web/priv/gettext/default.pot
#	apps/block_scout_web/priv/gettext/en/LC_MESSAGES/default.po
@gabitoesmiapodo
Copy link
Contributor Author

@vbaranov Sure, done.

gabitoesmiapodo and others added 7 commits June 3, 2019 10:38
@gabitoesmiapodo
(update) internationalization files
4462646
@gabitoesmiapodo
Merge branch 'master' into feature/#2038-new-network-selector
f7bbd2b 
* master:
  Update overview.html.eex
  Update CHANGELOG.md
  Update CHANGELOG.md
  (update) internationalization files
  (fix) failing test
  issues
  issues
  Update CHANGELOG.md
  added tooltip for more button, explorers logos added
  (update) changelog
  (update) internationalization files
  (fix) tablet styles
  (add) responsive styles
  (add) new contract verification UI js
  feat: add fields to tx apis, small cleanups
  (add) add libraries hide / show behavior
  (add) form radio buttons styles
  (add) tooltips text - form styles
  (add) new contract section styling

# Conflicts:
#	CHANGELOG.md
#	apps/block_scout_web/assets/css/app.scss
#	apps/block_scout_web/priv/gettext/default.pot
#	apps/block_scout_web/priv/gettext/en/LC_MESSAGES/default.po
@gabitoesmiapodo
(update) language files
a88e3d4
@gabitoesmiapodo
(fix) main container position when the network selector is showing
82a9770
@gabitoesmiapodo
Merge branch 'master' into feature/#2038-new-network-selector
922f337 
* master:
  Update CHANGELOG.md
  404 page added
  Update _tooltip.scss
  Update CHANGELOG.md
  Update _dropdown.scss
  Update _filter.scss
  Update _tooltip.scss
@gabitoesmiapodo
Merge branch 'master' into feature/#2038-new-network-selector
c672582 
* master:
  Update CHANGELOG.md

# Conflicts:
#	CHANGELOG.md
@maxgrapps
search network input functionality, add to favorites functionality
c66ec80
@maxgrapps maxgrapps mentioned this pull request Jun 19, 2019
Merged
vbaranov added a commit that referenced this pull request Jun 19, 2019
@vbaranov
#2044
636cb5f
maxgrapps and others added 6 commits June 20, 2019 10:19
@maxgrapps
eslint errors fix
972cc15
@maxgrapps
eslint fixes
3c7e83b
@maxgrapps
new icons for xdai, goerli, ropsten, fix for img path
ae27908
@maxgrapps
jslint test fix
1393edb
@vbaranov
Merge pull request #2197 from maxgrapps/feature/#2038-new-network-sel…
257a1d6 
…ector

Search network input functionality, add to favorites functionality, removed 'Show More Networks' button
@gabitoesmiapodo
Merge branch 'master' into feature/#2038-new-network-selector
2386fff 
* master: (180 commits)
  make block difficulty params optional
  feat: document eth rpc api mimicking endpoints
  feat: add eth_getLogs rpc endpoint
  Update CHANGELOG.md
  eth classic and sokol logos fix
  sokol and eth classic logo fix
  fix parity test
  Update CHANGELOG.md
  Update _footer.html.eex
  fix tests
  fix config
  increase request idle timeout
  Added additional chains, wobserver info
  fix test
  fix tests
  add CHANGELOG entry
  mix format
  use milliseconds in cache
  fix tests
  fix test
  ...

# Conflicts:
#	CHANGELOG.md
#	apps/block_scout_web/lib/block_scout_web/templates/layout/_topnav.html.eex
#	apps/block_scout_web/priv/gettext/default.pot
#	apps/block_scout_web/priv/gettext/en/LC_MESSAGES/default.po
@vbaranov
Copy link
Member

@maxgrapps here are the bugs I found:

  1. Stars should be coloured on the Favourites tab

Screenshot 2019-06-21 at 22 22 29

  1. Seems, it is a consequence of the 1st issue. If to click to the star on the Favourites tab, the doubled row appears

  2. Sokol testnet is selected, but I am on Mainnet. Nothing should be selected.

Screenshot 2019-06-21 at 22 23 01

@maxgrapps maxgrapps mentioned this pull request Jun 24, 2019
Merged
@vbaranov
Copy link
Member

@maxgrapps in order to increase usability could you add an ability to close the dropdown on click outside of dropdown?

@vbaranov vbaranov merged commit 2a226dc into master Jun 27, 2019
@vbaranov vbaranov deleted the feature/#2038-new-network-selector branch June 27, 2019 16:03
@mrsmkl mrsmkl mentioned this pull request Dec 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbaranov vbaranov Awaiting requested review from vbaranov

@ayrat555 ayrat555 Awaiting requested review from ayrat555

Assignees

@gabitoesmiapodo gabitoesmiapodo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(Feature) New Network Selector
4 participants
@gabitoesmiapodo @coveralls @vbaranov @maxgrapps