Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce max_concurrency of BlocksTransactionsMismatch #2070

Merged

Conversation

pasqu4le
Copy link
Contributor

@pasqu4le pasqu4le commented May 30, 2019

Motivation

Due to the excessive pressure that this temporary fetcher puts on the CPU and the database, the max_concurrency has been reduced to just 1.

Checklist for your PR

  • I added an entry to CHANGELOG.md with this PR
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • I checked whether I should update the docs and did so if necessary

@pasqu4le pasqu4le self-assigned this May 30, 2019
@pasqu4le pasqu4le added the ready for review This PR is ready for reviews. label May 30, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5136c09c-04fa-47cc-b2f2-129c209c7025

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.2%) to 80.674%

Files with Coverage Reduction New Missed Lines %
apps/ethereum_jsonrpc/test/support/ethereum_jsonrpc/case/geth/http_websocket.ex 1 0.0%
apps/ethereum_jsonrpc/test/support/ethereum_jsonrpc/web_socket/case/geth.ex 4 0.0%
apps/ethereum_jsonrpc/lib/ethereum_jsonrpc/web_socket/web_socket_client.ex 5 77.5%
Totals Coverage Status
Change from base Build f0e7a751-cb83-49fd-ad0d-152211164560: -0.2%
Covered Lines: 4763
Relevant Lines: 5904

💛 - Coveralls

@vbaranov vbaranov merged commit 90f55c5 into master May 31, 2019
@vbaranov vbaranov deleted the reduce-concurrency-of-block-transaction-mismatch-fetcher branch May 31, 2019 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants