Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Feature) Changes for new smart contract page #2071

Merged
merged 14 commits into from
Jun 3, 2019
Merged

(Feature) Changes for new smart contract page #2071

merged 14 commits into from
Jun 3, 2019

Conversation

gabitoesmiapodo
Copy link
Contributor

@gabitoesmiapodo gabitoesmiapodo commented May 30, 2019 •
edited
Loading

Closes #1726

Motivation

To update styles for the new smart contract page.

It's a 'generic' implementation. Particular details and colors should be implemented in each theme.

Changelog

Enhancements

  • Updated styles for the new smart contract page.

Some screenshots.

localhost_4000_address_0x4d45578b70a4a1b850f4519d5a16b89f6f50699a_contract_verifications(Laptop with MDPI screen)
localhost_4000_address_0x4d45578b70a4a1b850f4519d5a16b89f6f50699a_contract_verifications(Laptop with MDPI screen) (1)
localhost_4000_address_0x4d45578b70a4a1b850f4519d5a16b89f6f50699a_contract_verifications(iPad)
localhost_4000_address_0x4d45578b70a4a1b850f4519d5a16b89f6f50699a_contract_verifications(Nexus 6P)

Checklist for your PR

  • I added an entry to CHANGELOG.md with this PR
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • I checked whether I should update the docs and did so if necessary

@gabitoesmiapodo
(add) new contract section styling
2a08ccc
@gabitoesmiapodo
(add) tooltips text - form styles
948c04c
@gabitoesmiapodo
(add) form radio buttons styles
da08847
@gabitoesmiapodo
(add) add libraries hide / show behavior
c773173
@gabitoesmiapodo
(add) new contract verification UI js
4753fc8
@gabitoesmiapodo
(add) responsive styles
55c44fc
@gabitoesmiapodo
Merge branch 'master' into feature/#1726-changes-for-new-smart-contra…
459242d 
…ct-page

* master:
  Add CHANGELOG entry
  Increase timeout for geth indexers
  add CHANGELOG entry
  fix credo
  allow bytes32 for name and symbol
  add CHANGELOG entry for async pagination
  fix: show creating internal transactions
  fix: use better queries for listLogs endpoint
  fix: use better queries for listLogs endpoint
  Add consensus filter to AddRefetchNeededToBlock migration
  Fix BlocksTransactionsMismatch temporary fetcher
@gabitoesmiapodo
(fix) tablet styles
2d020e6
@gabitoesmiapodo
(update) internationalization files
0070ecd
@gabitoesmiapodo gabitoesmiapodo self-assigned this May 30, 2019
@gabitoesmiapodo gabitoesmiapodo changed the title Feature/#1726 changes for new smart contract page (Feature) Changes for new smart contract page May 30, 2019
@coveralls
Copy link

coveralls commented May 30, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 3d77a8f8-84ca-43ee-a6ac-9773a6ddf9ac

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 79.258%
Files with Coverage Reduction New Missed Lines %
apps/indexer/lib/indexer/transform/addresses.ex 1 79.17%
Totals Coverage Status
Change from base Build 5256d833-7ae6-4c55-be81-7d6a3bd087b8: 0.0%
Covered Lines: 4719
Relevant Lines: 5954
💛 - Coveralls

@ayrat555
Copy link
Contributor

One test is failing.
rename |> fill_in(text_field("Enter the Solidity Contract Code below"), with: source_code)
to |> fill_in(text_field("Enter the Solidity Contract Code"), with: source_code)

gabitoesmiapodo and others added 4 commits June 3, 2019 10:31
@gabitoesmiapodo
(fix) failing test
3368c82
@gabitoesmiapodo
Merge branch 'master' into feature/#1726-changes-for-new-smart-contra…
085861f 
…ct-page

* master: (68 commits)
  fix CHANGELOG
  Update overview.html.eex
  Update CHANGELOG.md
  ui issues
  Update CHANGELOG.md
  blockscout theme new logo
  Add files via upload
  new logo for blockscout theme
  Update CHANGELOG.md
  blockscout theme
  (update) changelog
  (update) internationalization files
  (fix) commented out %> tag was showing
  (fix) missing checkmarks
  update CHANGELOG with PR 2070
  Reduce max_concurrency of BlocksTransactionsMismatch
  Add CHANGELOG entry and add 1.3.15 changelog
  Docsify setup
  Add docs folder for docsify integration
  stop click twice
  ...

# Conflicts:
#	CHANGELOG.md
#	apps/block_scout_web/assets/css/app.scss
#	apps/block_scout_web/priv/gettext/default.pot
#	apps/block_scout_web/priv/gettext/en/LC_MESSAGES/default.po
@gabitoesmiapodo
(update) internationalization files
64304af
@vbaranov
Merge branch 'master' into feature/#1726-changes-for-new-smart-contra…
c170f23 
…ct-page
@vbaranov vbaranov merged commit 3a238c2 into master Jun 3, 2019
@vbaranov vbaranov deleted the feature/#1726-changes-for-new-smart-contract-page branch June 3, 2019 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbaranov vbaranov vbaranov approved these changes

@ayrat555 ayrat555 Awaiting requested review from ayrat555

Assignees

@gabitoesmiapodo gabitoesmiapodo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI changes for "New Smart Contract" page
4 participants
@gabitoesmiapodo @coveralls @ayrat555 @vbaranov