Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Fix) ETC theme fixes #2090

Merged
merged 8 commits into from
Jun 5, 2019
Merged

(Fix) ETC theme fixes #2090

merged 8 commits into from
Jun 5, 2019

Conversation

gabitoesmiapodo
Copy link
Contributor

Related to #1664 (comment)

Motivation

Main changes were implemented on #1922 but I've found a few discrepancies that I addressed here. Links to the updated design can be found at #1664 (comment)

@import "theme/base_variables"; and @import "ethereum_classic_variables"; should be uncommented.

New network selector present in the design won't be styled until it's implemented.

Fixes (screenshots are before the changes):

Screen Shot 2019-06-03 at 12 13 01

Swapped Market Cap and Price colors.
Corrected background gradient color and orientation.
Fixed block number color.

Screen Shot 2019-06-03 at 15 40 29

Corrected addresses and block number's colors.

Screen Shot 2019-06-03 at 15 21 07

Corrected social icon's color.

Changelog

Bug Fixes

  • ETC theme colors.

Checklist for your PR

  • I added an entry to CHANGELOG.md with this PR
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • I checked whether I should update the docs and did so if necessary

@gabitoesmiapodo gabitoesmiapodo self-assigned this Jun 3, 2019
@gabitoesmiapodo gabitoesmiapodo changed the title Fix/etc theme fixes (Fix) ETC theme fixes Jun 3, 2019
@coveralls
Copy link

coveralls commented Jun 3, 2019

Pull Request Test Coverage Report for Build 1d86870b-9e4d-44e9-ba21-4e6ab08fe9c2

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 80.86%

Files with Coverage Reduction New Missed Lines %
apps/indexer/lib/indexer/block/catchup/fetcher.ex 2 69.23%
apps/indexer/lib/indexer/fetcher/replaced_transaction.ex 2 90.91%
Totals Coverage Status
Change from base Build ce4cc9d5-f1fb-4dff-b5cd-4dc431039b49: -0.07%
Covered Lines: 4816
Relevant Lines: 5956

💛 - Coveralls

* master:
  Update CHANGELOG.md
vbaranov added a commit that referenced this pull request Jun 4, 2019
@vbaranov vbaranov merged commit 07398f7 into master Jun 5, 2019
@vbaranov vbaranov deleted the fix/etc-theme-fixes branch June 5, 2019 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants