Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide dropdown menu then other networks list is empty #2151

Merged
merged 2 commits into from
Jun 13, 2019

Conversation

saneery
Copy link
Contributor

@saneery saneery commented Jun 12, 2019

#2132

Motivation

Then SUPPORTED_CHAINS is [], we should hide the dropdown menu on the header

Before

Screenshot from 2019-06-12 17 32 09

After

Screenshot from 2019-06-12 17 25 59

@saneery saneery added the ready for review This PR is ready for reviews. label Jun 12, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 24b26f09-a6ef-4843-97a8-3896384ee690

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.1%) to 80.715%

Files with Coverage Reduction New Missed Lines %
apps/indexer/lib/indexer/fetcher/token.ex 1 78.57%
apps/indexer/lib/indexer/fetcher/token_balance.ex 2 87.1%
apps/indexer/lib/indexer/fetcher/internal_transaction.ex 3 58.62%
apps/indexer/lib/indexer/block/fetcher.ex 3 88.0%
Totals Coverage Status
Change from base Build 2e95c516-1e18-48e1-90e9-f00ed0466d7a: -0.1%
Covered Lines: 4901
Relevant Lines: 6072

💛 - Coveralls

@vbaranov vbaranov merged commit 51c5d6f into master Jun 13, 2019
@vbaranov vbaranov deleted the link-to-other-networks branch June 13, 2019 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants