Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix pending transaction query #2155

Merged
merged 7 commits into from
Jun 17, 2019
Merged

fix pending transaction query #2155

merged 7 commits into from
Jun 17, 2019

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented Jun 13, 2019 •
edited
Loading

with #2149 fixes #1612

Motivation

I found two issues in the pending transaction query:

  • view rendering was failing because created_contract_address association wasn't loaded
  • the slowest part of the query is ordering by hash and inserted_at fields so I added an index

Changelog

  • fix pending transaction query

@coveralls
Copy link

coveralls commented Jun 13, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build d5194485-083a-4608-bdc8-d475a54dd4b8

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.716%
Totals Coverage Status
Change from base Build 56d03bfc-3e44-4c5b-9a79-70592fbbfd9d: 0.0%
Covered Lines: 4918
Relevant Lines: 6093
💛 - Coveralls

@ayrat555 ayrat555 mentioned this pull request Jun 13, 2019
Closed
@vbaranov vbaranov merged commit f843349 into master Jun 17, 2019
@vbaranov vbaranov deleted the ab-fix-pending-transaction-query branch June 17, 2019 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachdaniel zachdaniel zachdaniel approved these changes

@saneery saneery saneery approved these changes

@pasqu4le pasqu4le pasqu4le approved these changes

@vbaranov vbaranov Awaiting requested review from vbaranov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve performance of pending txs page
6 participants
@ayrat555 @coveralls @zachdaniel @saneery @pasqu4le @vbaranov