Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sort blocks by timestamp when calculating average block time #2165

Merged
merged 5 commits into from
Jun 17, 2019
Merged

sort blocks by timestamp when calculating average block time #2165

merged 5 commits into from
Jun 17, 2019

Conversation

ayrat555
Copy link
Contributor

fixes #2152

Motivation

we were considering uncles but the result was wrong if uncles weren't sorted by timestamp

Changelog

  • sort blocks by timestamp when calculating average block time

@coveralls
Copy link

coveralls commented Jun 13, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build ed94a355-31c0-4fa8-8860-bfb7fd7ba098

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 80.863%
Files with Coverage Reduction New Missed Lines %
apps/explorer/lib/explorer/chain/transaction_count_cache.ex 2 84.21%
Totals Coverage Status
Change from base Build 344c70a7-d6b0-4226-9560-629ed85773d1: 0.1%
Covered Lines: 4910
Relevant Lines: 6072
💛 - Coveralls

vbaranov added a commit that referenced this pull request Jun 13, 2019
@vbaranov
#2165
5b54771
@vbaranov vbaranov merged commit 765103c into master Jun 17, 2019
@vbaranov vbaranov deleted the ab-consider-uncles-when-calculating-block-time branch June 17, 2019 17:39
@ayrat555 ayrat555 mentioned this pull request Jun 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachdaniel zachdaniel zachdaniel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to consider uncle blocks when calculating average block time
4 participants
@ayrat555 @coveralls @zachdaniel @vbaranov