Removes duplicate entries from Indexer.Fetcher.UncleBlock #2177
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2154
Resolves #2048
Motivation
Sometimes the same uncle gets fetched more than once in the same batch, causing the updating query to fail. As a solution, the Fetcher input entries are deduplicated.
Bug Fixes
I was not able to pinpoint the cause of the duplicate, but my best guess is that it is related by the asynchronicity of the fetching that causes
Explorer.Chain.stream_unfetched_uncles
to refetch an uncle before it's imported and itsuncle_fetched_at
gets set.Given that the results from processing multiple times the same entry are the same and that there are no particular constraints
on_conflict
forSecondDegreeRelations
, the solution consists in simply eliminating the duplicates from the fetcher entries.Checklist for your PR
CHANGELOG.md
with this PR