fix metadata decoding in smart contract verification #2225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayrat555
changed the title
Pull Request Test Coverage Report for Build d35dfe1a-7a3d-422d-ab37-cda6f0159661
💛 - Coveralls |
pasqu4le
approved these changes
Jun 24, 2019
CHANGELOG.md
Outdated
| @@ -42,7 +42,8 @@ | |||
| - [#2173](https://github.com/poanetwork/blockscout/pull/2173) - handle correctly empty transactions | |||
| - [#2174](https://github.com/poanetwork/blockscout/pull/2174) - fix reward channel joining | |||
| - [#2186](https://github.com/poanetwork/blockscout/pull/2186) - fix net version test | |||
| - [#2167](https://github.com/poanetwork/blockscout/pull/2168) - feat: document eth rpc api mimicking endpoints | |||
| - [#2167](https://github.com/poanetwork/blockscout/pull/2168) - feat: document eth rpc api mimicking endpoints | |||
There was a problem hiding this comment.
I just noticed that the link does not correspond to the correct PR number here (#2167)
saneery
approved these changes
Jun 24, 2019
vbaranov
approved these changes
Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2213
fixes https://blockscout.com/eth/mainnet/address/0x07cf8f81852a58dd26fa19e69545f72e263347e5/transactions in #2181
Motivation
Metadata encoded in bytecode was changed in Solidity 0.5.9
https://github.com/ethereum/solidity/blob/aa4ee3a1559ebc0354926af962efb3fcc7dc15bd/docs/metadata.rst
Changelog