Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix internal transactions failing to be indexed because of constraint #2244

Merged
merged 1 commit into from
Jul 2, 2019
Merged

Fix internal transactions failing to be indexed because of constraint #2244

merged 1 commit into from
Jul 2, 2019

Conversation

pasqu4le
Copy link
Contributor

##Motivation

This solves a recurring error from Explorer.Chain.Import.Runner.InternalTransactions that prevents internal transactions to be imported because the respective transaction fail to be updated.

Changelog

Bug Fixes

The bug causing the problem is that when transactions have already their status set, the insertion of internal_transactions will not change it to reflect the existence of an error.

Checklist for your PR

  • I added an entry to CHANGELOG.md with this PR
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • I checked whether I should update the docs and did so if necessary

@pasqu4le pasqu4le added the ready for review This PR is ready for reviews. label Jun 25, 2019
@pasqu4le pasqu4le self-assigned this Jun 25, 2019
@pasqu4le pasqu4le changed the title Fix internal transactions failing to insert because of transaction's Fix internal transactions failing to be indexed because of constraint Jun 25, 2019
@pasqu4le pasqu4le force-pushed the fix_internal_transaction_check_error branch from 8297de4 to 33ebf32 Compare June 25, 2019 16:43
@coveralls
Copy link

coveralls commented Jun 25, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build e0261ad8-6c9a-4f76-ab8c-a4b9729d0d8f

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.996%
Totals Coverage Status
Change from base Build b04dff0d-b2e9-4513-ae39-2d96b23f76b8: 0.0%
Covered Lines: 5106
Relevant Lines: 6304
💛 - Coveralls

vbaranov added a commit that referenced this pull request Jun 27, 2019
@vbaranov
#2244
f85c152
vbaranov
vbaranov approved these changes Jun 28, 2019
View reviewed changes
apps/explorer/test/explorer/chain/import/runner/internal_transactions_test.exs Outdated
alias Explorer.Chain.Import.Runner.InternalTransactions

describe "run/1" do
test "transaction status gets set to :error when internal transactions has an error" do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@pasqu4le pasqu4le force-pushed the fix_internal_transaction_check_error branch from 9996f4c to 32305b6 Compare July 2, 2019 14:53
@vbaranov vbaranov merged commit c9b215e into master Jul 2, 2019
@vbaranov vbaranov deleted the fix_internal_transaction_check_error branch July 2, 2019 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbaranov vbaranov vbaranov approved these changes

@ayrat555 ayrat555 ayrat555 approved these changes

@saneery saneery saneery approved these changes

@Heimdell Heimdell Awaiting requested review from Heimdell

Assignees

@pasqu4le pasqu4le

Labels
ready for review This PR is ready for reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pasqu4le @coveralls @vbaranov @ayrat555 @saneery