Modify implementation of where_transaction_has_multiple_internal_transactions
#2267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ltiple_internal_transactions` Problem: the implementation of that `WHERE` filter is too inefficient. In particular this was brought to attention because it causes `Explorer.Etherscan.list_internal_transactions/2` to timeout for some addresses. (For example: address `0x1B3858E01CCE5d0491f3c96A9996a65607f3493b`) Solution: while keeping the same result the previous check for siblings (SELECT/LIMIT 2/COUNT/(> 1)) has been replaced by a less expensive one that better uses the existing indexes (EXISTS/index comparison).
pasqu4le
force-pushed
the
pp-change-where_transaction_has_multiple_internal_transactions-implementation
branch
from
93ccbba
to
453d042
Compare
Pull Request Test Coverage Report for Build bf5b5480-f892-4158-8201-f5f9ec78401a
💛 - Coveralls |
vbaranov
approved these changes
Jul 3, 2019
ayrat555
approved these changes
Jul 3, 2019
…nternal_transactions-implementation
vbaranov
deleted the
pp-change-where_transaction_has_multiple_internal_transactions-implementation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2076
Changelog
Enhancements
While keeping the same result as the previous check for siblings (SELECT/LIMIT 2/COUNT/(> 1)) the new implementation is less expensive by using the existing indexes (EXISTS/index comparison).
Checklist for your PR
CHANGELOG.mdwith this PR