Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove port in docs #2276

Merged
merged 2 commits into from
Jul 2, 2019
Merged

remove port in docs #2276

merged 2 commits into from
Jul 2, 2019

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented Jul 1, 2019

Motivation

As part of #2193 some links in docs weren't fixed

Changelog

  • remove port in docs

@vbaranov vbaranov self-requested a review July 1, 2019 19:31
vbaranov
vbaranov approved these changes Jul 1, 2019
View reviewed changes
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayrat555 please add changelog entry

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2532bd76-b45f-4dda-b546-f8bb70097eaa

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 81.028%
Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/lib/block_scout_web/channels/exchange_rate_channel.ex 1 50.0%
Totals Coverage Status
Change from base Build 6eefae68-17ed-4aaf-b0d2-674ca67f5774: -0.02%
Covered Lines: 5108
Relevant Lines: 6304
💛 - Coveralls

@ayrat555 ayrat555 requested review from pasqu4le and saneery July 2, 2019 08:07
@vbaranov vbaranov merged commit 98c6a63 into master Jul 2, 2019
@vbaranov vbaranov deleted the ab-remove-port-in-docs branch July 2, 2019 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbaranov vbaranov vbaranov approved these changes

@saneery saneery saneery approved these changes

@pasqu4le pasqu4le Awaiting requested review from pasqu4le

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ayrat555 @coveralls @vbaranov @saneery