Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add 404 status for not existing pages #2284

Merged
merged 3 commits into from
Jul 2, 2019
Merged

add 404 status for not existing pages #2284

merged 3 commits into from
Jul 2, 2019

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented Jul 2, 2019

resolves #2280

Changelog

  • add 404 status for not existing pages

@coveralls
Copy link

coveralls commented Jul 2, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 65fb3cd4-e588-4cff-bee0-62fc0beb8766

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.1%) to 81.012%
Files with Coverage Reduction New Missed Lines %
apps/indexer/lib/indexer/fetcher/token.ex 1 78.57%
apps/indexer/lib/indexer/fetcher/internal_transaction.ex 2 58.62%
apps/indexer/lib/indexer/fetcher/token_balance.ex 2 87.88%
apps/indexer/lib/indexer/block/fetcher.ex 3 88.0%
apps/explorer/lib/explorer/market/market_history_cache.ex 3 83.33%
Totals Coverage Status
Change from base Build 9e79511b-3042-47a9-a369-2d2a57e4ec7a: -0.1%
Covered Lines: 5107
Relevant Lines: 6304
💛 - Coveralls

vbaranov added a commit that referenced this pull request Jul 2, 2019
@vbaranov
#2284
7a8f975
@vbaranov vbaranov merged commit 0759d4d into master Jul 2, 2019
@vbaranov vbaranov deleted the ab-not-found-status branch July 2, 2019 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbaranov vbaranov vbaranov approved these changes

@pasqu4le pasqu4le pasqu4le approved these changes

@saneery saneery Awaiting requested review from saneery

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

404 page should return 404 error code, not 200
4 participants
@ayrat555 @coveralls @vbaranov @pasqu4le