Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add healthy block period checking endpoint #2294

Merged
merged 5 commits into from
Jul 5, 2019
Merged

add healthy block period checking endpoint #2294

merged 5 commits into from
Jul 5, 2019

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented Jul 4, 2019 •
edited
Loading

Resolves #2273

curl http://localhost:4000/api/v1/health

Changelog

  • add healthy block period checking endpoint

@ayrat555 ayrat555 marked this pull request as ready for review July 4, 2019 10:43
@coveralls
Copy link

coveralls commented Jul 4, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 975dacfc-118a-4ded-8288-0c5e2a987f39

  • 18 of 18 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 80.996%
Totals Coverage Status
Change from base Build 386557a0-9cf0-4a24-8713-5ca6d5b6b50f: 0.05%
Covered Lines: 5170
Relevant Lines: 6383
💛 - Coveralls

@ayrat555 ayrat555 changed the title add healthy block period checking query add healthy block period checking endpoint Jul 4, 2019
pasqu4le
pasqu4le approved these changes Jul 4, 2019
View reviewed changes
Copy link
Contributor

@pasqu4le pasqu4le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I only left a refactoring suggestion

apps/block_scout_web/lib/block_scout_web/controllers/api/v1/health_controller.ex Outdated Show resolved Hide resolved
vbaranov
vbaranov requested changes Jul 4, 2019
View reviewed changes
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayrat555

The idea here #2272 was to create a single endpoint to check the healthiness of Blockscout. Checking of stuck blocks #2273 is the first component of this endpoint. We will extend this endpoint in the future with the new metrics. Basically, this endpoint should be bind to:
curl http://localhost:4000/api/v1/health

@ayrat555
Copy link
Contributor Author

ayrat555 commented Jul 4, 2019

@vbaranov I made changes according to your comment

@vbaranov vbaranov merged commit 3a10347 into master Jul 5, 2019
@vbaranov vbaranov deleted the ab-block-health-endpoint branch July 5, 2019 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbaranov vbaranov vbaranov approved these changes

@saneery saneery saneery approved these changes

@pasqu4le pasqu4le pasqu4le approved these changes

@Heimdell Heimdell Awaiting requested review from Heimdell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Health API: check the latest block in the db
5 participants
@ayrat555 @coveralls @vbaranov @saneery @pasqu4le