Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix market history overriding with zeroes #2311

Merged
merged 4 commits into from
Jul 10, 2019

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented Jul 8, 2019

Motivation

Service API that we're using for market history fetching started returning zeroes for some coins.

Changelog

  • fix market history overriding with zeroes

@coveralls
Copy link

coveralls commented Jul 8, 2019

Pull Request Test Coverage Report for Build 01f86562-3cbf-4993-b2c7-70c77b20d95e

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 80.97%

Totals Coverage Status
Change from base Build 8bb611b1-1c92-4a5d-bd04-3df8310dc8fc: 0.01%
Covered Lines: 5174
Relevant Lines: 6390

💛 - Coveralls

vbaranov added a commit that referenced this pull request Jul 8, 2019
Copy link
Contributor

@pasqu4le pasqu4le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment

vbaranov added a commit that referenced this pull request Jul 9, 2019
vbaranov added a commit that referenced this pull request Jul 10, 2019
@vbaranov vbaranov merged commit f350662 into master Jul 10, 2019
@vbaranov vbaranov deleted the ab-fix-market-history-overriding branch July 10, 2019 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants