Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page performance: exclude moment.js localization files except EN, remove unused css #2378

Merged
merged 1 commit into from
Jul 18, 2019
Merged

Page performance: exclude moment.js localization files except EN, remove unused css #2378

merged 1 commit into from
Jul 18, 2019

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Jul 17, 2019 •
edited
Loading

A part of #2390

Motivation

Before:
Screenshot 2019-07-18 at 00 45 22

After:
Screenshot 2019-07-18 at 00 47 37

Changelog

  • Configuration of webpack to exclude moment.js localization files except EN
  • Removal of unused css

Checklist for your PR

  • I added an entry to CHANGELOG.md with this PR
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • I checked whether I should update the docs and did so if necessary

@vbaranov vbaranov added the ready for review This PR is ready for reviews. label Jul 17, 2019
@vbaranov vbaranov self-assigned this Jul 17, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build ec43609d-8a47-44a4-959b-6214f7aa51ea

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.93%
Totals Coverage Status
Change from base Build eb6404ac-7c9f-453d-ab5d-45a2d93d12dd: 0.0%
Covered Lines: 5203
Relevant Lines: 6429
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3af11149-a9f5-4e74-9cd2-39c7316c14a5

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.93%
Totals Coverage Status
Change from base Build eb6404ac-7c9f-453d-ab5d-45a2d93d12dd: 0.0%
Covered Lines: 5203
Relevant Lines: 6429
💛 - Coveralls

@vbaranov vbaranov merged commit eab9b2e into master Jul 18, 2019
@vbaranov vbaranov deleted the performance-js-css branch July 18, 2019 12:25
@vbaranov vbaranov mentioned this pull request Jul 19, 2019
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayrat555 ayrat555 ayrat555 approved these changes

@saneery saneery saneery approved these changes

@pasqu4le pasqu4le pasqu4le approved these changes

@Heimdell Heimdell Awaiting requested review from Heimdell

Assignees

@vbaranov vbaranov

Labels
ready for review This PR is ready for reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vbaranov @coveralls @ayrat555 @saneery @pasqu4le