Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump otp version to 22.0 #2402

Merged
merged 7 commits into from
Aug 1, 2019
Merged

bump otp version to 22.0 #2402

merged 7 commits into from
Aug 1, 2019

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented Jul 22, 2019 •
edited
Loading

Changelog

  • bump otp version to 22.0
  • bump elixir to 1.9.1

Note: circle ci didn't prepare image with elixir 1.9.1 yet

@vbaranov vbaranov self-requested a review July 22, 2019 18:02
vbaranov
vbaranov reviewed Jul 22, 2019
View reviewed changes
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: circle ci didn't prepare image with elixir 1.9.1 yet

We will be able to merge this update when the image will be prepared

@ayrat555
Copy link
Contributor Author

ayrat555 commented Aug 1, 2019

@vbaranov elixir 1.9.1 image is now available

@coveralls
Copy link

coveralls commented Aug 1, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 0c877797-db06-4d0a-955a-b03b3eacc349

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.265%
Totals Coverage Status
Change from base Build c49d5f25-83c9-4412-b651-f9aecb6f0de9: 0.0%
Covered Lines: 5157
Relevant Lines: 6506
💛 - Coveralls

@ayrat555 ayrat555 added ready for review This PR is ready for reviews. and removed do not merge labels Aug 1, 2019
@vbaranov vbaranov self-requested a review August 1, 2019 08:00
vbaranov
vbaranov approved these changes Aug 1, 2019
View reviewed changes
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayrat555 changelog entry is missing

@ayrat555
Copy link
Contributor Author

ayrat555 commented Aug 1, 2019

@vbaranov it's there https://github.com/poanetwork/blockscout/pull/2402/files#diff-4ac32a78649ca5bdd8e0ba38b7006a1eR11

@ayrat555 ayrat555 merged commit 7004563 into master Aug 1, 2019
@ayrat555 ayrat555 deleted the ab-upgrade-otp-version branch August 1, 2019 12:50
@snyk-bot snyk-bot mentioned this pull request Mar 17, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbaranov vbaranov vbaranov approved these changes

@saneery saneery saneery approved these changes

@pasqu4le pasqu4le pasqu4le approved these changes

Assignees
No one assigned
Labels
ready for review This PR is ready for reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ayrat555 @coveralls @vbaranov @saneery @pasqu4le