Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return gasPrice at gettxinfo API's method #2403

Merged
merged 3 commits into from
Aug 8, 2019
Merged

Conversation

saneery
Copy link
Contributor

@saneery saneery commented Jul 22, 2019

#2348

Motivation

Add gasPrice field at the result of gettinfo method

  • I added an entry to CHANGELOG.md with this PR
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • I checked whether I should update the docs and did so if necessary

@coveralls
Copy link

Pull Request Test Coverage Report for Build 0a74354c-01f8-4786-bbe8-51d7c5cba9e2

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 80.933%

Totals Coverage Status
Change from base Build e8dae500-635c-4255-b6c3-0243d5e67b8e: 0.003%
Covered Lines: 5204
Relevant Lines: 6430

💛 - Coveralls

@saneery saneery added ready for review This PR is ready for reviews. api API endpoints labels Jul 22, 2019
vbaranov added a commit that referenced this pull request Jul 22, 2019
@ayrat555
Copy link
Contributor

Please add json schema test so we won't lose anything in the future

@saneery
Copy link
Contributor Author

saneery commented Jul 23, 2019

Please add json schema test so we won't lose anything in the future

@ayrat555 what the schema? where can I find an example?

@ayrat555
Copy link
Contributor

@saneery https://en.wikipedia.org/wiki/JSON#JSON_Schema

we didn't test JSON schema yet but I think it's time to start. this PR is a good opportunity https://github.com/jonasschmidt/ex_json_schema

@ayrat555
Copy link
Contributor

ayrat555 commented Aug 8, 2019

@saneery are you going to resolve my comment? I didn't get an answer in 2 weeks

@saneery
Copy link
Contributor Author

saneery commented Aug 8, 2019

@ayrat555 maybe it should be different PR since we need to add a new dependency?
Maybe we should create a new issue to add JSON schema tests?

@vbaranov vbaranov mentioned this pull request Aug 8, 2019
@vbaranov vbaranov merged commit 16343d4 into master Aug 8, 2019
@vbaranov vbaranov deleted the gettxinfo-gas-price-field branch August 8, 2019 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api API endpoints ready for review This PR is ready for reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants