Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preload smart contract for logs decoding #2410

Merged
merged 4 commits into from
Jul 23, 2019
Merged

preload smart contract for logs decoding #2410

merged 4 commits into from
Jul 23, 2019

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented Jul 23, 2019 •
edited
Loading

Currently, we're not decoding logs for transaction logs even if the smart contract is verified.
It always says

To see decoded input data, the contract must be verified.

For example, https://blockscout.com/eth/mainnet/tx/0x411bbb944fb40ae5229705827e6e553206b1a45209b8beab4bb4ac64c359c7b9/logs

The issue is caused by the fact that we're not preloading a smart contract in the transaction

after adding preload
img

Changelog

  • preload smart contract for logs decoding

@coveralls
Copy link

coveralls commented Jul 23, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 72190f80-63e8-4f45-90c0-520f1d7fb173

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 79.786%
Totals Coverage Status
Change from base Build 37e4be4c-dc93-4813-a37f-1eb1d4471d47: 0.02%
Covered Lines: 5139
Relevant Lines: 6441
💛 - Coveralls

vbaranov added a commit that referenced this pull request Jul 23, 2019
@vbaranov
#2410
389ed4e
@vbaranov vbaranov merged commit 6f4b068 into master Jul 23, 2019
@vbaranov vbaranov deleted the ab-preload-smart-contract-for-logs-decoding branch July 23, 2019 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbaranov vbaranov vbaranov approved these changes

@saneery saneery saneery approved these changes

@pasqu4le pasqu4le pasqu4le approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ayrat555 @coveralls @vbaranov @saneery @pasqu4le