Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clearance of logs and node_modules folders in clearing script #2450

Merged
merged 2 commits into from
Jul 29, 2019
Merged

Fix clearance of logs and node_modules folders in clearing script #2450

merged 2 commits into from
Jul 29, 2019

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Jul 26, 2019 •
edited
Loading

Motivation

Clearing script doesn't clear all ./node_modules and /logs/dev folders

Changelog

Add removal of all /logs/dev folders and all /node_modules excluding hidden folders and files

Checklist for your PR

  • I added an entry to CHANGELOG.md with this PR
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • I checked whether I should update the docs and did so if necessary

@coveralls
Copy link

coveralls commented Jul 26, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 52678e35-1440-4e35-8c0e-50a2e6efb144

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 79.445%
Totals Coverage Status
Change from base Build 3fb8356a-eb04-49db-aa1d-7377ef332d3c: 0.03%
Covered Lines: 5152
Relevant Lines: 6485
💛 - Coveralls

@vbaranov vbaranov changed the title Update clear_build.sh Fix clearance of logs and node_modules folders in clearing script Jul 26, 2019
@vbaranov vbaranov self-assigned this Jul 26, 2019
@vbaranov vbaranov added the ready for review This PR is ready for reviews. label Jul 26, 2019
@vbaranov vbaranov merged commit 9c198a6 into master Jul 29, 2019
@vbaranov vbaranov deleted the vbaranov-patch-1 branch July 29, 2019 11:14
ghost
ghost reviewed Jul 20, 2021
View reviewed changes
CHANGELOG.md
@@ -5,6 +5,7 @@
### Fixes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayrat555 ayrat555 ayrat555 approved these changes

@saneery saneery saneery approved these changes

@pasqu4le pasqu4le pasqu4le approved these changes

@Heimdell Heimdell Awaiting requested review from Heimdell

Assignees

@vbaranov vbaranov

Labels
ready for review This PR is ready for reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vbaranov @coveralls @ayrat555 @saneery @pasqu4le