Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LAST_BLOCK var to index range of blocks #2458

Merged
merged 5 commits into from
Aug 1, 2019
Merged

Add LAST_BLOCK var to index range of blocks #2458

merged 5 commits into from
Aug 1, 2019

Conversation

saneery
Copy link
Contributor

@saneery saneery commented Jul 29, 2019

#2443

Motivation

Added a new environment variable LAST_BLOCK to index blocks in the range

pasqu4le
pasqu4le approved these changes Jul 29, 2019
View reviewed changes
Copy link
Contributor

@pasqu4le pasqu4le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saneery there is no entry in the changelog

@coveralls
Copy link

coveralls commented Jul 29, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 3aac221a-a4c8-4af4-b99f-c4213aa7f242

  • 4 of 5 (80.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 79.286%
Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/indexer/lib/indexer/block/catchup/fetcher.ex 4 5 80.0%
Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 2 71.43%
Totals Coverage Status
Change from base Build 392cda83-d665-47aa-89a0-8a94226ff8c2: -0.03%
Covered Lines: 5152
Relevant Lines: 6498
💛 - Coveralls

@saneery saneery requested a review from vbaranov July 30, 2019 10:57
@saneery
Copy link
Contributor Author

saneery commented Jul 30, 2019

@vbaranov I've updated env-variables.md, could you look into this?

@vbaranov
Copy link
Member

@saneery yep, looks fine. Let me test the solution.

@vbaranov vbaranov mentioned this pull request Jul 30, 2019
Closed
vbaranov added a commit that referenced this pull request Jul 31, 2019
@vbaranov
#2458
93a4c85
@vbaranov vbaranov merged commit c938041 into master Aug 1, 2019
@vbaranov vbaranov deleted the reindexing-range branch August 1, 2019 10:23
@vbaranov vbaranov mentioned this pull request Aug 1, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbaranov vbaranov vbaranov approved these changes

@ayrat555 ayrat555 ayrat555 approved these changes

@pasqu4le pasqu4le pasqu4le approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@saneery @coveralls @vbaranov @ayrat555 @pasqu4le