import emission reward ranges

[ayrat555]

a part of #2493
fixes #2489
closes #2080

Changelog

• import emission reward ranges

Upgrading

All you need to do is set CHAIN_SPEC_PATH env var with parity chain specification or create a similar specification with emission reward ranges and genesis account balances.

I'll abstract this logic for POA Network in the next PR

[coveralls]

Pull Request Test Coverage Report for Build c32976dc-11e5-4a02-9327-e351a3e81b9d

• 31 of 52 (59.62%) changed or added relevant lines in 3 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.2%) to 79.032%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
apps/explorer/lib/explorer/chain/block/emission_reward.ex	0	1	0.0%
apps/explorer/lib/explorer/chain_spec/genesis_data.ex	3	23	13.04%

Totals
Change from base Build 40ef733c-0c96-4391-964b-9a12e1e93cb8:	-0.2%
Covered Lines:	5190
Relevant Lines:	6567

---

💛 - Coveralls

[vbaranov]

@ayrat555 PR checklist👮 is here. You introduced a new ENV VAR and didn't add to the list of PRs in corresponding MD file. I would suggest not to clear checklist but look over it and add necessary marks.

Also, it is hard to tell how the solution works without description. Please, clarify how the solution works. It will help to find possible bugs in the logic before we published it into production.

[ayrat555]

@vbaranov done

[vbaranov]

@ayrat555

Please set master for Version column. Because we cannot know for sure, that it will be a part of 2.0.3 release. I will update the version before release.

All you need to do is set CHAIN_SPEC_PATH env var with parity chain specification or create a similar specification with emission reward ranges and genesis account balances.

• Should it be a local file?
• absolute/relative path?
• Could it be a link to a chain spec on Github, for instance

I think we should support both options (local file/link). For public chains, it is preferable to use the latter option since spec is published in Github.

[ayrat555]

@vbaranov currently it only supports absolute path. I'll implement fetching from url now

[ayrat555]

@vbaranov I added the ability to fetch from remote url

[vbaranov]

@ayrat555

• which DB tables do you fill with data from chain spec?
• Where do you write genesis balances?

[vbaranov]

@ayrat555 getminedblocks is still unusable because it returns 502 Error, I suppose, because of a huge amount of blocks. We should add pagination for this query.

[ayrat555]

@vbaranov emission_rewards table is populated for emission ranges

[ayrat555]

@vbaranov address_coin_balances is populated for genesis balances

[vbaranov]

@ayrat555

@vbaranov address_coin_balances is populated for genesis balances

stg: /address/0xebd37b256563e30c6f9289a8e2702f0852880833/coin_balances

The same is for every address from the genesis block. How is the date for the genesis block chosen?

[ayrat555]

@vbaranov I think that's a bug
https://blockscout.com/poa/core/blocks/0/transactions
https://blockscout.com/eth/mainnet/blocks/0/transactions

[ayrat555]

I created an issue #2546

[vbaranov]

@ayrat555 I removed "fixing" keyword for #2493 because this PR doesn't fix that issue completely due to

@ayrat555 getminedblocks is still unusable because it returns 502 Error, I suppose, because of a huge amount of blocks. We should add pagination for this query.

[ayrat555]

@vbaranov will you create a separate issue?

[vbaranov]

@vbaranov will you create a separate issue?

No. I would just suggest not to close #2493 with this PR. Because that issue is definitely clear: API endpoint doesn't work. And this PR is the 1st step to resolve that issue.

[ayrat555]

sounds good to me