Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not aggregate NFT token transfers #2515

Merged
merged 7 commits into from
Aug 8, 2019
Merged

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented Aug 7, 2019

fixes

2019-08-07T09:59:35.684 [error] #PID<0.4717.0> running BlockScoutWeb.Endpoint (connection #PID<0.4713.0>, stream id 2) terminated
Server: localhost:4000 (http)
Request: GET /tx/0x3a8589b18bd39dd9c16c7552dae18ffb5670daa57b59c63d45cbf43f4a2a89dc/token_transfers
** (exit) an exception was raised:
    ** (FunctionClauseError) no function clause matching in Decimal.decimal/1
        (decimal) lib/decimal.ex:1911: Decimal.decimal(nil)
        (decimal) lib/decimal.ex:333: Decimal.add/2
        (block_scout_web) lib/block_scout_web/views/transaction_view.ex:55: anonymous fn/2 in BlockScoutWeb.TransactionView.aggregate_token_transfers/1
        (elixir) lib/enum.ex:1948: Enum."-reduce/3-lists^foldl/2-0-"/3
        (block_scout_web) lib/block_scout_web/views/transaction_view.ex:44: BlockScoutWeb.TransactionView.aggregate_token_transfers/1
        (block_scout_web) lib/block_scout_web/templates/transaction/overview.html.eex:180: BlockScoutWeb.TransactionView."overview.html"/1
        (block_scout_web) lib/block_scout_web/templates/transaction_token_transfer/index.html.eex:2: BlockScoutWeb.TransactionTokenTransferView."index.html"/1
        (block_scout_web) lib/block_scout_web/templates/layout/app.html.eex:44: BlockScoutWeb.LayoutView."app.html"/1
        (phoenix) lib/phoenix/view.ex:399: Phoenix.View.render_to_iodata/3
        (phoenix) lib/phoenix/controller.ex:729: Phoenix.Controller.__put_render__/5
        (block_scout_web) lib/block_scout_web/endpoint.ex:1: BlockScoutWeb.Endpoint.instrument/4
        (phoenix) lib/phoenix/controller.ex:746: Phoenix.Controller.instrument_render_and_send/4
        (block_scout_web) lib/block_scout_web/controllers/transaction_token_transfer_controller.ex:1: BlockScoutWeb.TransactionTokenTransferController.action/2
        (block_scout_web) lib/block_scout_web/controllers/transaction_token_transfer_controller.ex:1: BlockScoutWeb.TransactionTokenTransferController.phoenix_controller_pipeline/2
        (block_scout_web) lib/block_scout_web/endpoint.ex:1: BlockScoutWeb.Endpoint.instrument/4
        (phoenix) lib/phoenix/router.ex:275: Phoenix.Router.__call__/1
        (block_scout_web) lib/block_scout_web/endpoint.ex:1: BlockScoutWeb.Endpoint.plug_builder_call/2
        (block_scout_web) lib/plug/debugger.ex:122: BlockScoutWeb.Endpoint."call (overridable 3)"/2
        (block_scout_web) lib/block_scout_web/endpoint.ex:1: BlockScoutWeb.Endpoint."call (overridable 4)"/2
        (block_scout_web) lib/spandex_phoenix.ex:156: BlockScoutWeb.Endpoint.call/2

Changelog

  • do not aggregate NFT token transfers

@coveralls
Copy link

coveralls commented Aug 7, 2019

Pull Request Test Coverage Report for Build 842519a9-23b1-4af0-9aee-a6606073ba2d

  • 14 of 14 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 79.313%

Totals Coverage Status
Change from base Build c025ab3e-d6aa-4d31-b8d9-ef4582b1a804: 0.02%
Covered Lines: 5172
Relevant Lines: 6521

💛 - Coveralls

@vbaranov vbaranov merged commit 16976de into master Aug 8, 2019
@vbaranov vbaranov deleted the ab-do-not-aggregate-nft branch August 8, 2019 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants