Avoid importing internal_transactions of pending transactions #2523
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves:
Motivation
The problem happens because while fetching internal transactions for a block sometimes we receive some that are part of a pending transaction (or at least a transaction that is still registered in the database as pending).
By inserting them we also try to update the pending transaction's field, but this violates the
status
check constraint (and rightfully so).Changelog
Bug Fixes
The solution is to filter out internal_transactions that are part of a pending transaction before trying to insert them.
Checklist for your PR
CHANGELOG.md
with this PR