Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show both eth value and token transfers #2529

Merged
merged 7 commits into from
Aug 9, 2019
Merged

show both eth value and token transfers #2529

merged 7 commits into from
Aug 9, 2019

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented Aug 8, 2019

img

fixes #2522

Changelog

  • show both eth value and token transfers

@coveralls
Copy link

coveralls commented Aug 8, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 94327bf2-8436-4f35-a931-b3d5ba40d14f

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 79.304%
Totals Coverage Status
Change from base Build 086b4558-4a71-4fc5-bfe7-c36311357434: 0.02%
Covered Lines: 5196
Relevant Lines: 6552
💛 - Coveralls

vbaranov
vbaranov requested changes Aug 8, 2019
View reviewed changes
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stg: /tx/0x33ee933dc7b0cc7545f3d1d5d5f1db263c951af6773fff7fd82fe8de2e87d777/internal_transactions

Screenshot 2019-08-08 at 16 58 26

@ayrat555
Copy link
Contributor Author

ayrat555 commented Aug 8, 2019 •
edited
Loading

@vbaranov fixed. I forgot = symbol for eex

@vbaranov vbaranov self-requested a review August 8, 2019 16:46
vbaranov
vbaranov reviewed Aug 8, 2019
View reviewed changes
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayrat555 could you fix stuck token transfer value and ticker?

@ayrat555
Copy link
Contributor Author

ayrat555 commented Aug 8, 2019

@vbaranov done

@vbaranov vbaranov self-requested a review August 9, 2019 06:30
@vbaranov
Copy link
Member

vbaranov commented Aug 9, 2019

@ayrat555 gettext test should be fixed. Could you do that?

@ayrat555
Copy link
Contributor Author

ayrat555 commented Aug 9, 2019

@vbaranov done

@vbaranov vbaranov merged commit 994ac77 into master Aug 9, 2019
@vbaranov vbaranov deleted the ab-show-token-transfers-with-eth-value branch August 9, 2019 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbaranov vbaranov vbaranov approved these changes

@saneery saneery saneery approved these changes

@pasqu4le pasqu4le pasqu4le approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Token transfer summary when non-zero ether value sent
5 participants
@ayrat555 @coveralls @vbaranov @saneery @pasqu4le