Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find decoding candidates for logs #2555

Merged
merged 22 commits into from
Aug 29, 2019

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented Aug 12, 2019

resolves #2521

Changelog

  • find decoding candidates for logs

@coveralls
Copy link

coveralls commented Aug 15, 2019

Pull Request Test Coverage Report for Build eca4991c-f1ce-47b6-bd97-45230506d952

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 78.961%

Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 1 78.57%
Totals Coverage Status
Change from base Build 1385cffa-8b48-4e5a-8a34-989c43676879: 0.02%
Covered Lines: 5198
Relevant Lines: 6583

💛 - Coveralls

@ayrat555 ayrat555 changed the title [WIP] find decoding candidates for logs find decoding candidates for logs Aug 16, 2019
@ayrat555 ayrat555 requested review from zachdaniel, vbaranov, pasqu4le and saneery and removed request for zachdaniel August 16, 2019 08:49
Copy link
Contributor

@pasqu4le pasqu4le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments/question

Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayrat555

2019-08-22T18:03:13.689 [error] #PID<0.3095.108> running BlockScoutWeb.Endpoint (connection #PID<0.3068.108>, stream id 10) terminated
Request: GET /address/0x64348e36c3978017ff9fe6ae3465da4add6ce481/logs?type=JSON
** (exit) an exception was raised:
    ** (ArgumentError) assign @transaction not available in eex template.

Please make sure all proper assigns have been set. If this
is a child template, ensure assigns are given explicitly by
the parent template as they are not automatically forwarded.

Available assigns: [:conn, :log, :view_module, :view_template]

        (phoenix_html) lib/phoenix_html/engine.ex:133: Phoenix.HTML.Engine.fetch_assign!/2
        (block_scout_web) lib/block_scout_web/templates/address_logs/_logs.html.eex:8: BlockScoutWeb.AddressLogsView."_logs.html"/1
        (phoenix) lib/phoenix/view.ex:399: Phoenix.View.render_to_iodata/3
        (phoenix) lib/phoenix/view.ex:406: Phoenix.View.render_to_string/3
        (elixir) lib/enum.ex:1336: Enum."-map/2-lists^map/1-0-"/2
        (block_scout_web) lib/block_scout_web/controllers/address_logs_controller.ex:34: BlockScoutWeb.AddressLogsController.index/2
        (block_scout_web) lib/block_scout_web/controllers/address_logs_controller.ex:1: BlockScoutWeb.AddressLogsController.action/2
        (block_scout_web) lib/block_scout_web/controllers/address_logs_controller.ex:1: BlockScoutWeb.AddressLogsController.phoenix_controller_pipeline/2

The error is from stg server. I am not sure is it because of merging conflicts or bug in the current branch. Please check.

Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayrat555 are the changes in package-lock.json intentional?

@ayrat555
Copy link
Contributor Author

@vbaranov I reverted these changes

@vbaranov vbaranov merged commit 130162d into master Aug 29, 2019
@vbaranov vbaranov deleted the ab-decode-decoding-cadidates-for-logs branch August 29, 2019 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decoding candidates for logs
5 participants