Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dark theme flickering #2562

Merged
merged 2 commits into from
Aug 13, 2019
Merged

Fix dark theme flickering #2562

merged 2 commits into from
Aug 13, 2019

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Aug 13, 2019

Motivation

When the page is loading or user switches between pages with the dark mode applied, the light mode is loading first and then dark mode applied after a while.

Changelog

Bug Fixes

Raise the priority of dark theme class applying to window.onload event.

Checklist for your PR

@vbaranov vbaranov force-pushed the vb-fix-dark-theme-flickering branch from 777ba97 to aec4438 Compare August 13, 2019 12:05
@vbaranov vbaranov requested review from pasqu4le, saneery, ayrat555 and Heimdell and removed request for pasqu4le August 13, 2019 12:06
@ayrat555
Copy link
Contributor

@vbaranov gettext is failing

@vbaranov vbaranov force-pushed the vb-fix-dark-theme-flickering branch from aec4438 to e7f88a2 Compare August 13, 2019 12:17
@vbaranov
Copy link
Member Author

@vbaranov gettext is failing

Thanks, fixed

@vbaranov vbaranov merged commit 0da12aa into master Aug 13, 2019
@vbaranov vbaranov deleted the vb-fix-dark-theme-flickering branch August 13, 2019 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants