Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade absinthe phoenix #2566

Merged
merged 10 commits into from
Aug 14, 2019
Merged

upgrade absinthe phoenix #2566

merged 10 commits into from
Aug 14, 2019

Conversation

ayrat555
Copy link
Contributor

I updated my fork of absinthe_phoenix. Now, absinthe_phoenix should be updated here.
Note that my PR with default query in absinthe_plug was merged in the upstream repo so we can move to the upstream when they release a stable version.

Also, I regenerated mix.lock file which removed some unused deps.

Changelog

  • upgrade absinthe phoenix
  • regenerate mix.lock

pasqu4le
pasqu4le approved these changes Aug 14, 2019
View reviewed changes
Copy link
Contributor

@pasqu4le pasqu4le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one question, but the rest looks fine

apps/block_scout_web/test/block_scout_web/views/api_docs_view_test.exs Show resolved Hide resolved
@vbaranov vbaranov merged commit ff51294 into master Aug 14, 2019
@vbaranov vbaranov deleted the ab-upgrade-absinthe-phoenix branch August 14, 2019 11:12
@ayrat555 ayrat555 mentioned this pull request Aug 20, 2019
Closed
ayrat555 added a commit that referenced this pull request Aug 20, 2019
@ayrat555
use older version of phoenix framework
18848fe 
In the PR (#2566) phoenix
was updated to `1.4.9`. But apparently new changes cause web socket
connection to disconnect and connect again which shows `Connection
Closed` message. We should investigate this issue and update phoenix
framework after that - #2595
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbaranov vbaranov vbaranov approved these changes

@saneery saneery saneery approved these changes

@pasqu4le pasqu4le pasqu4le approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ayrat555 @vbaranov @saneery @pasqu4le