Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ease non-critical css #2572

Merged
merged 2 commits into from
Aug 15, 2019
Merged

Ease non-critical css #2572

merged 2 commits into from
Aug 15, 2019

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Aug 14, 2019

Motivation

Some styles from critical css unintentionally copied to non-critical css by importing variables.scss in #2514

Changelog

Enhancements

variables-non-critical.scss created with the theme vars/styles related only to non-critical css.

Checklist for your PR

@vbaranov vbaranov self-assigned this Aug 14, 2019
@vbaranov vbaranov added the ready for review This PR is ready for reviews. label Aug 14, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8b52c9e9-3772-43fd-b64b-ca3b830311bf

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.186%

Totals Coverage Status
Change from base Build 40ef733c-0c96-4391-964b-9a12e1e93cb8: 0.0%
Covered Lines: 5159
Relevant Lines: 6515

💛 - Coveralls

@vbaranov vbaranov merged commit 4e20066 into master Aug 15, 2019
@vbaranov vbaranov deleted the vb-non-critical-css-ease branch August 15, 2019 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants